Skip to content

[ENHANCEMENT] Improving Windows compatibility and general readability across Chapter 2 and 3 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 5, 2021

Conversation

jatinpapreja
Copy link
Contributor

Windows support has been missing. In #15 and #13, there are a few workarounds given but these changes aims to improve a new user's experience by providing clear instructions to run notebooks on Windows.
We have also tried to make some outputs more readable by truncating them to reduce the size of the notebook while still providing a clear picture of the output as well as marking up some headings for a quick overview.

@kartikay-bagla
Copy link
Collaborator

I cannot test Ch2 Nb5 as the link there is broken. Mentioned in #43. @varunp2k any updates on it?

@kartikay-bagla
Copy link
Collaborator

Similarly link also broken in Ch3 Nb6. Mentioned in #46. @varunp2k

@kartikay-bagla kartikay-bagla merged commit ccbf828 into practical-nlp:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants