Skip to content

[BUG] spelling_en.txt link not working #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jatinpapreja opened this issue Mar 23, 2021 · 2 comments · Fixed by #48
Closed

[BUG] spelling_en.txt link not working #43

jatinpapreja opened this issue Mar 23, 2021 · 2 comments · Fixed by #48
Assignees
@varunp2k
Labels
bug Something isn't working

Comments

@jatinpapreja
Copy link
Contributor

jatinpapreja commented Mar 23, 2021 •
edited
Loading

This template is ONLY to be used for reporting bugs in the code.

Location

chapter 2 notebook 5

Current Behavior

(https://github.com/makcedward/nlpaug/blob/master/model/spelling_en.txt) link is not working

Resolving github.com (github.com)... 52.69.186.44
Connecting to github.com (github.com)|52.69.186.44|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2021-03-23 16:21:46 ERROR 404: Not Found.

Expected Behavior

Possible Solution

Steps to Reproduce

  1. run the notebook

Context (Environment)

using colab

Possible Implementation
@jatinpapreja jatinpapreja added the bug Something isn't working label Mar 23, 2021
@jatinpapreja jatinpapreja changed the title [BUG] wikimedia link not working [BUG] spelling_en.txt link not working Mar 31, 2021
@kartikay-bagla kartikay-bagla mentioned this issue Apr 1, 2021
Merged
@kartikay-bagla kartikay-bagla linked a pull request Apr 1, 2021 that will close this issue
[ENHANCEMENT] Improving Windows compatibility and general readability across Chapter 2 and 3 #48
Merged
@varunp2k
Copy link
Collaborator

varunp2k commented Apr 3, 2021 •
edited
Loading

This link has been moved to https://github.com/makcedward/nlpaug/blob/5238e0be734841b69651d2043df535d78a8cc594/nlpaug/res/word/spelling/spelling_en.txt
@kartikay-bagla @jkapila

@kartikay-bagla
Copy link
Collaborator

@jatinpapreja can you update the link and test the notebook? If it works, you can add a commit in the PR which fixes this issue.

kartikay-bagla added a commit to jatinpapreja/practical-nlp that referenced this issue Apr 3, 2021
@kartikay-bagla
fixes practical-nlp#43 and adds better downloading and windows suppor…
c44f267 
…t to ch2 nb5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varunp2k varunp2k

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@kartikay-bagla @varunp2k @jatinpapreja