ensure TLS string options are properly inherited (regression) #18547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
changed the title
bukka
approved these changes
May 14, 2025
There was a problem hiding this comment.
I think this is an improvement. I don't have time to properly verify but based on what was described, it makes sense to me.
Would be probably good to wait @rainerjung to confirm that it fixes issue for him too.
|
Wow, thanks for taking the hard way. I will rebuild 8.4.7 with this PR on top and run the tests plus our local tests that showed the original problem. I should be able to report back tomorrow. |
ericmann
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18529 regression in 8.3.21 and 8.4.7
This also fix the tests issue
ldaps_basic.phptwas failing (XFAIL) because of ldap.conf (TLS_CACERT) set in setup-slapd.shldap_start_tls_basic.phptwas passing because global options not properly inheritedUsing
LDAPNOINIT=1ensure ldap.conf is not used, so the local cert cannot be verified.