Code

Make FFI callbacks thread safe#12823

Code

Draft

smx-smx wants to merge 28 commits intophp:masterphp/php-src:masterfrom

smx-smx:ffi-ts-mastersmx-smx/php-src:ffi-ts-masterCopy head branch name to clipboard

Commits

Commits on Nov 29, 2023

• ffi: thread safe callbacks (preliminary)

  smx-smx

  committed
  16be72b

  Copy full SHA for 16be72b

• ffi: make sure there are no in progress requests before posting a new one

  Show description for 1de9669
  smx-smx

  committed
  1de9669

  Copy full SHA for 1de9669

• code style

  smx-smx

  committed
  56c24d4

  Copy full SHA for 56c24d4

• ffi: trace the requester and main thread IDs

  smx-smx

  committed
  6423d3a

  Copy full SHA for 6423d3a

• ffi: fix deadlock when the callback invocation is from the main thread

  smx-smx

  committed
  98eb079

  Copy full SHA for 98eb079

• ffi: add tests/callback_threads

  smx-smx

  committed
  d762cfe

  Copy full SHA for d762cfe

• ffi: fix mutex unlock before zend_error_noreturn (fixes bug79177.phpt)

  smx-smx

  committed
  29d6550

  Copy full SHA for 29d6550

• ffi: remove wrongly placed restore of interrupt handler

  Show description for ba483e6
  smx-smx

  committed
  ba483e6

  Copy full SHA for ba483e6

Commits on Nov 30, 2023

• ffi: have callbacks be handled by the thread that invoked them

  smx-smx

  committed
  bce091d

  Copy full SHA for bce091d

• ffi: fix bug79177 once again

  smx-smx

  committed
  083cc9e

  Copy full SHA for 083cc9e

• ffi: cleanup

  smx-smx

  committed
  34353aa

  Copy full SHA for 34353aa

Commits on Dec 1, 2023

• ffi: initialize stack info for the new thread

  smx-smx

  committed
  9164b16

  Copy full SHA for 9164b16

• ffi: fix vm_ack <-> vm_unlock deadlock

  Show description for 20dd9b1
  smx-smx

  committed
  20dd9b1

  Copy full SHA for 20dd9b1

Commits on Dec 2, 2023

• ffi: add missing includes for php_ffi.h

  Show description for e20a564
  smx-smx

  committed
  e20a564

  Copy full SHA for e20a564

• enable TSRM mutex APIs outside of ZTS

  smx-smx

  committed
  af12a99

  Copy full SHA for af12a99

• tsrm: add cond API (POSIX only for now)

  smx-smx

  committed
  261a1d3

  Copy full SHA for 261a1d3

Commits on Dec 3, 2023

• zend_globals_macros.h: add missing include

  smx-smx

  committed
  2f71fa3

  Copy full SHA for 2f71fa3

• ffi: first version using fibers for callbacks

  smx-smx

  committed
  391ca94

  Copy full SHA for 391ca94

• ffi: fix tests

  Show description for e8b2b5f
  smx-smx

  committed
  e8b2b5f

  Copy full SHA for e8b2b5f

• tsrm: implement win32 cond API

  smx-smx

  committed
  e2fce83

  Copy full SHA for e2fce83

• fix build errors

  smx-smx

  committed
  dc5496f

  Copy full SHA for dc5496f

Commits on Apr 30, 2025

• Fix GH-13215 GCC 14 build

  

  remicollet

  authored and

  smx-smx

  committed
  37ee7de

  Copy full SHA for 37ee7de

• zend_ffi_callback_trampoline: fix build without ZEND_CHECK_STACK_LIMIT

  smx-smx

  committed
  d2b2192

  Copy full SHA for d2b2192

• Merge commit '87d75328b2ac3cc6fc0360ede8f70d324a70819f' into ffi-ts-master2

  smx-smx

  committed
  38f88d0

  Copy full SHA for 38f88d0

• Merge remote-tracking branch 'origin/master' into ffi-ts-master2

  smx-smx

  committed
  7e5697e

  Copy full SHA for 7e5697e

Commits on May 5, 2025

• ffi: fix crash in callback (by using zend_fiber_resume_internal instead of zend_fiber_resume)

  Show description for 6f6a737
  smx-smx

  committed
  6f6a737

  Copy full SHA for 6f6a737

• ffi: exceptions can now be thrown in PHP callbacks

  Show description for 9d2e24a
  smx-smx

  committed
  9d2e24a

  Copy full SHA for 9d2e24a

• ffi: fix test gh16013

  smx-smx

  committed
  bd953ba

  Copy full SHA for bd953ba