Skip to content

ext/date: various array optimisations. #18382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2025
Merged

ext/date: various array optimisations. #18382

merged 2 commits into from
May 12, 2025
+10 −8

Conversation

devnexen
Copy link
Member

pre-allocated sizes and/or packed arrays.

@devnexen
ext/date: various array optimisations.
885cad2 
pre-allocated sizes and/or packed arrays.
@devnexen devnexen requested a review from derickr as a code owner April 21, 2025 13:44
SakiTakamachi
SakiTakamachi approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

derickr
derickr approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - does it really make that much of a difference though?

@devnexen
Copy link
Member Author

devnexen commented May 12, 2025 •
edited
Loading

LGTM - does it really make that much of a difference though?

Not a ton indeed, but steady
image
image

@devnexen devnexen merged commit 4122daa into php:master May 12, 2025
9 checks passed
@devnexen devnexen deleted the date_array_optims branch May 12, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derickr derickr derickr approved these changes

@SakiTakamachi SakiTakamachi SakiTakamachi approved these changes

Assignees
No one assigned
Labels
Extension: date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devnexen @derickr @SakiTakamachi