Skip to content

Commit bfe7c69

Browse files
datibbawsmalyshev
authored andcommitted
Added more useful warning messages
1 parent 904dca6 commit bfe7c69

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

ext/standard/dns.c

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -897,13 +897,24 @@ PHP_FUNCTION(dns_get_record)
897897

898898
if (n < 0) {
899899
php_dns_free_handle(handle);
900-
if (h_errno == NO_DATA || h_errno == HOST_NOT_FOUND) {
901-
continue;
902-
} else {
903-
php_error_docref(NULL TSRMLS_CC, E_WARNING, "DNS Query failed");
904-
zval_dtor(return_value);
905-
RETURN_FALSE;
900+
switch (h_errno) {
901+
case NO_DATA:
902+
case HOST_NOT_FOUND:
903+
continue;
904+
905+
case NO_RECOVERY:
906+
php_error_docref(NULL TSRMLS_CC, E_WARNING, "An unexpected server failure occurred.");
907+
break;
908+
909+
case TRY_AGAIN:
910+
php_error_docref(NULL TSRMLS_CC, E_WARNING, "A temporary server error occurred.");
911+
break;
912+
913+
default:
914+
php_error_docref(NULL TSRMLS_CC, E_WARNING, "DNS Query failed");
906915
}
916+
zval_dtor(return_value);
917+
RETURN_FALSE;
907918
}
908919

909920
cp = answer.qb2 + HFIXEDSZ;

0 commit comments

Comments
 (0)