Skip to content

Commit 7ccd7b5

Browse files
datibbawsmalyshev
authored andcommitted
Added more useful warning messages
1 parent 0109eb0 commit 7ccd7b5

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

ext/standard/dns.c

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -896,13 +896,24 @@ PHP_FUNCTION(dns_get_record)
896896

897897
if (n < 0) {
898898
php_dns_free_handle(handle);
899-
if (h_errno == NO_DATA || h_errno == HOST_NOT_FOUND) {
900-
continue;
901-
} else {
902-
php_error_docref(NULL TSRMLS_CC, E_WARNING, "DNS Query failed");
903-
zval_dtor(return_value);
904-
RETURN_FALSE;
899+
switch (h_errno) {
900+
case NO_DATA:
901+
case HOST_NOT_FOUND:
902+
continue;
903+
904+
case NO_RECOVERY:
905+
php_error_docref(NULL TSRMLS_CC, E_WARNING, "An unexpected server failure occurred.");
906+
break;
907+
908+
case TRY_AGAIN:
909+
php_error_docref(NULL TSRMLS_CC, E_WARNING, "A temporary server error occurred.");
910+
break;
911+
912+
default:
913+
php_error_docref(NULL TSRMLS_CC, E_WARNING, "DNS Query failed");
905914
}
915+
zval_dtor(return_value);
916+
RETURN_FALSE;
906917
}
907918

908919
cp = answer.qb2 + HFIXEDSZ;

0 commit comments

Comments
 (0)