ext/standard: stream_get_filters() user filters list as packed arrays. (#18384)

devnexen · web-flow · commit 3b387ef27476 · 2025-04-21T17:03:35.000+01:00
diff --git a/ext/standard/user_filters.c b/ext/standard/user_filters.c
@@ -476,16 +476,19 @@ PHP_FUNCTION(stream_get_filters)
 
 	ZEND_PARSE_PARAMETERS_NONE();
 
-	array_init(return_value);
 
 	filters_hash = php_get_stream_filters_hash();
 
 	if (filters_hash && !HT_IS_PACKED(filters_hash)) {
+		array_init(return_value);
+		zend_hash_real_init_packed(Z_ARRVAL_P(return_value));
 		ZEND_HASH_MAP_FOREACH_STR_KEY(filters_hash, filter_name) {
 			if (filter_name) {
 				add_next_index_str(return_value, zend_string_copy(filter_name));
 			}
 		} ZEND_HASH_FOREACH_END();
+	} else {
+		RETURN_EMPTY_ARRAY();
 	}
 	/* It's okay to return an empty array if no filters are registered */
 }

Original file line number	Diff line number	Diff line change
`@@ -476,16 +476,19 @@ PHP_FUNCTION(stream_get_filters)`
`476`	`476`
`477`	`477`	`ZEND_PARSE_PARAMETERS_NONE();`
`478`	`478`
`479`		`- array_init(return_value);`
`480`	`479`
`481`	`480`	`filters_hash = php_get_stream_filters_hash();`
`482`	`481`
`483`	`482`	`if (filters_hash && !HT_IS_PACKED(filters_hash)) {`
	`483`	`+ array_init(return_value);`
	`484`	`+ zend_hash_real_init_packed(Z_ARRVAL_P(return_value));`
`484`	`485`	`ZEND_HASH_MAP_FOREACH_STR_KEY(filters_hash, filter_name) {`
`485`	`486`	`if (filter_name) {`
`486`	`487`	`add_next_index_str(return_value, zend_string_copy(filter_name));`
`487`	`488`	`}`
`488`	`489`	`} ZEND_HASH_FOREACH_END();`
	`490`	`+ } else {`
	`491`	`+ RETURN_EMPTY_ARRAY();`
`489`	`492`	`}`
`490`	`493`	`/* It's okay to return an empty array if no filters are registered */`
`491`	`494`	`}`