Skip to content

Commit 04f5da4

Browse files
committed
Avoid K&R style function declarations in sha1()
These are deprecated in C20.
1 parent 6ff662b commit 04f5da4

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

ext/standard/sha1.c

+3-11
Original file line numberDiff line numberDiff line change
@@ -247,9 +247,7 @@ PHPAPI void PHP_SHA1Final(unsigned char digest[20], PHP_SHA1_CTX * context)
247247
/* {{{ SHA1Transform
248248
* SHA1 basic transformation. Transforms state based on block.
249249
*/
250-
static void SHA1Transform(state, block)
251-
uint32_t state[5];
252-
const unsigned char block[64];
250+
static void SHA1Transform(uint32_t state[5], const unsigned char block[64])
253251
{
254252
uint32_t a = state[0], b = state[1], c = state[2];
255253
uint32_t d = state[3], e = state[4], x[16], tmp;
@@ -359,10 +357,7 @@ const unsigned char block[64];
359357
Encodes input (uint32_t) into output (unsigned char). Assumes len is
360358
a multiple of 4.
361359
*/
362-
static void SHA1Encode(output, input, len)
363-
unsigned char *output;
364-
uint32_t *input;
365-
unsigned int len;
360+
static void SHA1Encode(unsigned char *output, uint32_t *input, unsigned int len)
366361
{
367362
unsigned int i, j;
368363

@@ -379,10 +374,7 @@ unsigned int len;
379374
Decodes input (unsigned char) into output (uint32_t). Assumes len is
380375
a multiple of 4.
381376
*/
382-
static void SHA1Decode(output, input, len)
383-
uint32_t *output;
384-
const unsigned char *input;
385-
unsigned int len;
377+
static void SHA1Decode(uint32_t *output, const unsigned char *input, unsigned int len)
386378
{
387379
unsigned int i, j;
388380

0 commit comments

Comments
 (0)