Skip to content

symfony/polyfill-php80 should be moved to require section in composer.json file #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SOHELAHMED7 opened this issue Aug 30, 2024 · 0 comments · Fixed by #40
Closed

symfony/polyfill-php80 should be moved to require section in composer.json file #37

SOHELAHMED7 opened this issue Aug 30, 2024 · 0 comments · Fixed by #40
Assignees
@SOHELAHMED7

Comments

@SOHELAHMED7
Copy link
Member

I observed that polyfill package symfony/polyfill-php80 is used.

File: src/lib/items/RouteData.php::detectUrlPattern()

if (!str_starts_with(trim($this->path, '/'), trim($prefix, '/'))) {

It is present in require-dev section in composer.json

It should be present in require section
@SOHELAHMED7 SOHELAHMED7 self-assigned this Aug 30, 2024
@SOHELAHMED7 SOHELAHMED7 mentioned this issue Sep 3, 2024
Merged
@SOHELAHMED7 SOHELAHMED7 linked a pull request Sep 3, 2024 that will close this issue
Resolve symfony/polyfill-php80 should be moved to require section in composer.json file #37 #40
Merged
cebe added a commit that referenced this issue Nov 12, 2024
@cebe
Merge pull request #40 from php-openapi/37-symfonypolyfill-php80-shou…
5c53973 
…ld-be-moved-to-require-section-in-composerjson-file

Resolve symfony/polyfill-php80 should be moved to require section in composer.json file #37
@cebe cebe closed this as completed in #40 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SOHELAHMED7 SOHELAHMED7

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@SOHELAHMED7