Skip to content

Commit bf40f03

Browse files
committed
Send the client_encoding startup parameter value with more typical formatting
All non-alphanumerics are ignored, but `'utf-8'` is weird. `UTF8` is the canonical name, and is what libpq sends.
1 parent c8fb416 commit bf40f03

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

packages/pg-protocol/src/serializer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const startup = (opts: Record<string, string>): Buffer => {
2525
writer.addCString(key).addCString(opts[key])
2626
}
2727

28-
writer.addCString('client_encoding').addCString("'utf-8'")
28+
writer.addCString('client_encoding').addCString('UTF8')
2929

3030
var bodyBuffer = writer.addCString('').flush()
3131
// this message is sent without a code

packages/pg/lib/connection.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ Connection.prototype.startup = function (config) {
144144
writer.addCString(key).addCString(val)
145145
})
146146

147-
writer.addCString('client_encoding').addCString("'utf-8'")
147+
writer.addCString('client_encoding').addCString('UTF8')
148148

149149
var bodyBuffer = writer.addCString('').flush()
150150
// this message is sent without a code

packages/pg/test/unit/connection/outbound-sending-tests.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ test('sends startup message', function () {
2828
.addCString('database')
2929
.addCString('bang')
3030
.addCString('client_encoding')
31-
.addCString("'utf-8'")
31+
.addCString('UTF8')
3232
.addCString('')
3333
.join(true)
3434
)

0 commit comments

Comments
 (0)