Skip to content

Commit 96e2f20

Browse files
committed
test: Replace global BufferList with local require
Removes assigning BufferList to a global in top level test-helper and adds explicit require in the tests that need to access it.
1 parent 02c4fc5 commit 96e2f20

File tree

5 files changed

+5
-2
lines changed

5 files changed

+5
-2
lines changed

packages/pg/test/buffer-list.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict'
2-
global.BufferList = function () {
2+
3+
const BufferList = function () {
34
this.buffers = []
45
}
56
var p = BufferList.prototype

packages/pg/test/test-buffers.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict'
22
require('./test-helper')
3+
const BufferList = require('./buffer-list')
34
// http://developer.postgresql.org/pgdocs/postgres/protocol-message-formats.html
45

56
var buffers = {}

packages/pg/test/test-helper.js

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
global.assert = require('assert')
44
var sys = require('util')
55

6-
var BufferList = require('./buffer-list')
76
const Suite = require('./suite')
87
const args = require('./cli')
98

packages/pg/test/unit/client/md5-password-tests.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict'
22
var helper = require('./test-helper')
3+
const BufferList = require('../../buffer-list')
34
var utils = require('../../../lib/utils')
45

56
test('md5 authentication', function () {

packages/pg/test/unit/connection/inbound-parser-tests.js

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict'
22
require('./test-helper')
3+
const BufferList = require('../../buffer-list')
34
var Connection = require('../../../lib/connection')
45
var buffers = require('../../test-buffers')
56
var PARSE = function (buffer) {

0 commit comments

Comments
 (0)