Fix failing unit test (#2685)

Problem: Intermittently one of our unit tests was failing.

Solution: My hunch as to why it was failing is because of the parallel nature would occasionally cause an object to be in the wrong state for a specific test. So that object is now being defined for every test instead of globally.

Author: sjberman

internal/mode/static/config_updater_test.go

@@ -34,7 +34,6 @@ func TestUpdateControlPlane(t *testing.T) {
 	}
 
 	logger := zap.New()
-	fakeEventRecorder := record.NewFakeRecorder(1)
 	nsname := types.NamespacedName{Namespace: "test", Name: "test"}
 
 	tests := []struct {
@@ -82,6 +81,8 @@ func TestUpdateControlPlane(t *testing.T) {
 				},
 			}
 
+			fakeEventRecorder := record.NewFakeRecorder(1)
+
 			err := updateControlPlane(test.nginxGateway, logger, fakeEventRecorder, nsname, fakeLogSetter)
 
 			if test.expErrString != "" {