Skip to content

draft changes in run-kind #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

draft changes in run-kind #29

merged 2 commits into from
Apr 18, 2025

Conversation

elevran
Copy link
Collaborator

@elevran elevran commented Apr 18, 2025

most of the changes are to align with images being built (or failing to to be built) elsewhere.

To do:

  • install GIE CRDs on environment (infra task)
  • EPP missing correct args to make it run
  • vllm-sim deployment changed in separate PR from @mayabar which also included definitions of needed GIE CRs

@elevran
draft changes in run-kind
c9fd65b 
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
@elevran elevran requested a review from shaneutt April 18, 2025 11:23
@elevran elevran marked this pull request as draft April 18, 2025 11:23
shaneutt
shaneutt approved these changes Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of suggestions just to add the issues tracking the TODOs.

@shaneutt shaneutt marked this pull request as ready for review April 18, 2025 12:48
@shaneutt shaneutt merged commit be9c800 into neuralmagic:dev Apr 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elevran @shaneutt