-
Notifications
You must be signed in to change notification settings - Fork 313
/
Copy pathremoteKernelConnectionHandler.unit.test.ts
236 lines (218 loc) · 10 KB
/
remoteKernelConnectionHandler.unit.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
import { use } from 'chai';
import { anything, deepEqual, instance, mock, verify, when } from 'ts-mockito';
import { EventEmitter, NotebookDocument, Uri } from 'vscode';
import { ILiveRemoteKernelConnectionUsageTracker } from '../../kernels/jupyter/types';
import { dispose } from '../../platform/common/utils/lifecycle';
import { IDisposable } from '../../platform/common/types';
import chaiAsPromised from 'chai-as-promised';
import {
IKernel,
IKernelProvider,
IKernelSession,
isLocalConnection,
KernelActionSource,
KernelConnectionMetadata,
LiveRemoteKernelConnectionMetadata,
LocalKernelSpecConnectionMetadata,
RemoteKernelSpecConnectionMetadata
} from '../../kernels/types';
import { PreferredRemoteKernelIdProvider } from '../../kernels/jupyter/connection/preferredRemoteKernelIdProvider';
import { RemoteKernelConnectionHandler } from './remoteKernelConnectionHandler';
import { IControllerRegistration, IVSCodeNotebookController } from './types';
import { Kernel } from '@jupyterlab/services';
import { uriEquals } from '../../test/datascience/helpers';
use(chaiAsPromised);
suite('Remote kernel connection handler', async () => {
let tracker: ILiveRemoteKernelConnectionUsageTracker;
let preferredRemoteKernelProvider: PreferredRemoteKernelIdProvider;
let onDidStartKernel: EventEmitter<IKernel>;
let onNotebookControllerSelectionChanged: EventEmitter<{
selected: boolean;
notebook: NotebookDocument;
controller: IVSCodeNotebookController;
}>;
let remoteConnectionHandler: RemoteKernelConnectionHandler;
let controllers: IControllerRegistration;
let kernelProvider: IKernelProvider;
let disposables: IDisposable[] = [];
// const server2Uri = 'http://one:1234/hello?token=1234';
const remoteKernelSpec = RemoteKernelSpecConnectionMetadata.create({
baseUrl: 'baseUrl',
id: 'remoteKernelSpec1',
kernelSpec: {
argv: [],
display_name: '',
name: '',
executable: ''
},
serverProviderHandle: { handle: 'handle', id: 'id', extensionId: '' }
});
const localKernelSpec = LocalKernelSpecConnectionMetadata.create({
id: 'localKernelSpec1',
kernelSpec: {
argv: [],
display_name: '',
name: '',
executable: ''
}
});
const remoteLiveKernel1 = LiveRemoteKernelConnectionMetadata.create({
baseUrl: 'baseUrl',
id: 'connectionId',
kernelModel: {
lastActivityTime: new Date(),
id: 'model1',
model: {
id: 'modelId',
kernel: {
id: 'kernelId',
name: 'kernelName'
},
name: 'modelName',
path: '',
type: ''
},
name: '',
numberOfConnections: 0
},
serverProviderHandle: { handle: 'handle', id: 'id', extensionId: '' }
});
setup(() => {
onDidStartKernel = new EventEmitter<IKernel>();
kernelProvider = mock<IKernelProvider>();
controllers = mock<IControllerRegistration>();
tracker = mock<ILiveRemoteKernelConnectionUsageTracker>();
preferredRemoteKernelProvider = mock<PreferredRemoteKernelIdProvider>();
onNotebookControllerSelectionChanged = new EventEmitter<{
selected: boolean;
notebook: NotebookDocument;
controller: IVSCodeNotebookController;
}>();
disposables.push(onDidStartKernel);
disposables.push(onNotebookControllerSelectionChanged);
when(kernelProvider.onDidStartKernel).thenReturn(onDidStartKernel.event);
when(controllers.onControllerSelectionChanged).thenReturn(onNotebookControllerSelectionChanged.event);
when(preferredRemoteKernelProvider.storePreferredRemoteKernelId(anything(), anything())).thenResolve();
when(preferredRemoteKernelProvider.clearPreferredRemoteKernelId(anything())).thenResolve();
remoteConnectionHandler = new RemoteKernelConnectionHandler(
disposables,
instance(kernelProvider),
instance(controllers),
instance(tracker),
instance(preferredRemoteKernelProvider)
);
});
teardown(() => {
disposables = dispose(disposables);
});
test('Ensure event handler is added', () => {
remoteConnectionHandler.activate();
verify(kernelProvider.onDidStartKernel).once();
});
function verifyRemoteKernelTracking(connection: KernelConnectionMetadata, source: KernelActionSource) {
const kernel1 = mock<IKernel>();
when(kernel1.kernelConnectionMetadata).thenReturn(connection);
when(kernel1.creator).thenReturn('jupyterExtension');
const session = mock<IKernelSession>();
when(kernel1.session).thenReturn(instance(session));
const kernelConnection = mock<Kernel.IKernelConnection>();
when(session.kernel).thenReturn(instance(kernelConnection));
when(kernelConnection.id).thenReturn('_KernelId_');
const eventEmitter = new EventEmitter<void>();
disposables.push(eventEmitter);
when(kernel1.onDidKernelSocketChange).thenReturn(eventEmitter.event);
const nbUri = Uri.file('a.ipynb');
when(kernel1.resourceUri).thenReturn(nbUri);
when(kernel1.disposed).thenReturn(false);
when(kernel1.disposing).thenReturn(false);
remoteConnectionHandler.activate();
verify(tracker.trackKernelIdAsUsed(anything(), anything(), anything())).never();
verify(preferredRemoteKernelProvider.storePreferredRemoteKernelId(anything(), anything())).never();
onDidStartKernel.fire(instance(kernel1));
eventEmitter.fire();
if (connection.kind === 'startUsingRemoteKernelSpec' && source === 'jupyterExtension') {
verify(
tracker.trackKernelIdAsUsed(
uriEquals(nbUri),
deepEqual(remoteKernelSpec.serverProviderHandle),
'_KernelId_'
)
).atLeast(2);
verify(preferredRemoteKernelProvider.storePreferredRemoteKernelId(uriEquals(nbUri), '_KernelId_')).atLeast(
2
);
} else {
verify(tracker.trackKernelIdAsUsed(anything(), anything(), anything())).never();
verify(preferredRemoteKernelProvider.storePreferredRemoteKernelId(anything(), anything())).never();
}
}
function verifyRemoteKernelTrackingUponKernelSelection(connection: KernelConnectionMetadata, selected: boolean) {
const controller = mock<IVSCodeNotebookController>();
const notebook = mock<NotebookDocument>();
when(notebook.isClosed).thenReturn(false);
const nbUri = Uri.file('a.ipynb');
when(notebook.uri).thenReturn(nbUri);
when(controller.connection).thenReturn(connection);
remoteConnectionHandler.activate();
verify(tracker.trackKernelIdAsUsed(anything(), anything(), anything())).never();
verify(preferredRemoteKernelProvider.storePreferredRemoteKernelId(anything(), anything())).never();
onNotebookControllerSelectionChanged.fire({
controller: instance(controller),
notebook: instance(notebook),
selected
});
if (connection.kind === 'connectToLiveRemoteKernel') {
if (selected) {
verify(
tracker.trackKernelIdAsUsed(
nbUri,
deepEqual(remoteKernelSpec.serverProviderHandle),
connection.kernelModel.id!
)
).once();
} else {
verify(
tracker.trackKernelIdAsNotUsed(
nbUri,
deepEqual(remoteKernelSpec.serverProviderHandle),
connection.kernelModel.id!
)
).once();
}
} else {
verify(tracker.trackKernelIdAsUsed(anything(), anything(), anything())).never();
}
if (selected && isLocalConnection(connection)) {
verify(preferredRemoteKernelProvider.clearPreferredRemoteKernelId(nbUri)).once();
}
}
test('When starting a remote kernel spec ensure we track this', async () => {
verifyRemoteKernelTracking(remoteKernelSpec, 'jupyterExtension');
});
test('When starting a local kernel spec ensure we do not track this', async () => {
verifyRemoteKernelTracking(localKernelSpec, 'jupyterExtension');
});
test('When starting a local kernel spec from a 3rd party extension ensure we do not track this', async () => {
verifyRemoteKernelTracking(localKernelSpec, '3rdPartyExtension');
});
test('When starting a kernel related to a live kernel ensure we do not track this, as it will be tracked when the kernel is selected', async () => {
verifyRemoteKernelTracking(remoteLiveKernel1, 'jupyterExtension');
});
test('When starting a kernel related to a live kernel from a 3rd party extension ensure we do not track this', async () => {
verifyRemoteKernelTracking(remoteLiveKernel1, '3rdPartyExtension');
});
test('Upon selecting a local kernelspec, ensure we clear the preferred remote kernel & not track this kernel', () => {
verifyRemoteKernelTrackingUponKernelSelection(localKernelSpec, true);
});
test('Upon selecting a remote kernelspec, ensure we do not not track this kernel', () => {
verifyRemoteKernelTrackingUponKernelSelection(remoteKernelSpec, true);
});
test('Upon selecting a remote live kernel, ensure we track this kernel', () => {
verifyRemoteKernelTrackingUponKernelSelection(remoteLiveKernel1, true);
});
test('Upon un-selecting a remote live kernel, ensure we mark this kernel as no longer used', () => {
verifyRemoteKernelTrackingUponKernelSelection(remoteLiveKernel1, false);
});
});