Merge branch 'master' of https://github.com/JulianBirch/node-postgres into JulianBirch-master

Author: brianc

.gitignore

@@ -1 +1,2 @@
 /.emacs-project
+*.swp

lib/query.js

@@ -43,7 +43,7 @@ p.submit = function(connection) {
     };
   };
   var handleDatarow = function(msg) {
-    var result = [];
+    var result = {};
     for(var i = 0; i < msg.fields.length; i++) {
       var rawValue = msg.fields[i];
       result[names[i]] = rawValue === null ? null : converters[i](rawValue);

test/integration/client/simple-query-tests.js

@@ -4,14 +4,25 @@ test("simple query interface", function() {
 
   var client = helper.client();
 
-  var query = client.query("select name from person");
+  var query = client.query("select name from person order by name");
 
   client.on('drain', client.end.bind(client));
 
   var rows = [];
   query.on('row', function(row) {
     rows.push(row['name'])
   });
+  query.once('row', function(row) {
+    test('Can iterate through columns', function () {
+      var columnCount = 0;
+      for (column in row) {
+        columnCount++;
+      };
+      if ('length' in row) {
+        assert.length(row, columnCount, 'Iterating through the columns gives a different length from calling .length.');
+      }
+    });
+  });
 
   assert.emits(query, 'end', function() {
     test("returned right number of rows", function() {

test/integration/client/test-helper.js

@@ -10,6 +10,17 @@ module.exports = {
       host: helper.args.host,
       port: helper.args.port
     });
+    client.on('error', function(e, d) {
+      console.log(e);
+    });
+    var rawQuery = client.query;
+    client.query = function() {
+      var q = rawQuery.apply(this, arguments);
+      q.on('error', function(e) {
+        console.log(e);
+      });
+      return q;
+    };
     client.connect();
     return client;
   },

test/test-helper.js

@@ -10,6 +10,15 @@ buffers = require(__dirname + '/test-buffers');
 Connection = require('connection');
 var args = require(__dirname + '/cli');
 
+process.on('uncaughtException', function(d) {
+  if ('stack' in d && 'message' in d) {
+    console.log("Message: " + d.message);
+    console.log(d.stack);
+  } else {
+    console.log(d);
+  }
+});
+
 assert.same = function(actual, expected) {
   for(var key in expected) {
     assert.equal(actual[key], expected[key]);
@@ -102,6 +111,7 @@ assert.isNull = function(item, message) {
 
 test = function(name, action) {
   test.testCount ++;
+  console.log('\n' + name);
   var result = action();
   if(result === false) {
     test.ignored.push(name);