Take advantage of PHP >= 7.1 functionality #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use nullable types and void return type were possible. - Fix autodocs for non-static methods. - Update Travis configuration (use bionic and update to vips 8.10). - Update dependencies. - Improve install-vips.sh script.
Our development dependencies require newer versions of PHP.
jcupitt
reviewed
Aug 28, 2020
| @@ -111,7 +111,7 @@ def generate_operation(operation_name): | |||
| result += 'array ' | |||
|
|
|||
| result += '{0}('.format(operation_name) | |||
| for name in intro.required_input: | |||
| for name in intro.method_args: | |||
|
Oh, nice! PHP is a foreign (and slightly ugly) country to me, so this all looks great. I'll update gh-pages too. |
|
gh-pages updated too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install-vips.shscript.Note: It's been a while since I've done anything with PHP, so I might have overlooked some things.