Skip to content

Add ability to store prebuilt frameworks in shared cache folder #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Rag0n
Copy link

@Rag0n Rag0n commented May 1, 2019

Resolves #37

@leavez
Copy link
Owner

leavez commented May 9, 2019

Thank for the new feature implementation. But a fundamental question: How to identify the pod and its generated framework? There may be code in podfile to modify the generated pod targets, and it will lead to different build result.

@leavez leavez self-requested a review May 9, 2019 09:36
@Rag0n
Copy link
Author

Rag0n commented May 9, 2019

I don't understand your point. Could you provide a use case? I mean what do you want to modify in prebuilt framework? Cache is respecting custom build options set via set_custom_xcodebuild_options_for_prebuilt_frameworks. I don't see difference between using cache and not using it, probably I'm missing something.

@jaximan
Copy link

jaximan commented May 10, 2019

I guess case is when Podfile contains :binary => true only for few targets, not all of them. @Rag0n Thank you for this! Mind if I collaborate with you and add s3 remote cache on top of your implementation. My case is, having > 10 build machines and build/collect cache for frameworks on all of them is waste of resources.

@Rag0n
Copy link
Author

Rag0n commented May 10, 2019

But cache only works for :binary => true pods. Do you think we should add another flag to control cache behaviour for individual pods? From my point of you it's useless.

I would like to have S3 remote cache as well. @jaximan, do you want to implement it by yourself or you need some help?

@jaximan
Copy link

jaximan commented May 10, 2019

@Rag0n I can add it, would you like to have PR for your branch or as separate PR for this master after your change is merged?

@Rag0n
Copy link
Author

Rag0n commented May 10, 2019

I think PR for this branch will be faster, but it's up to you.

jaximan and others added 4 commits May 10, 2019 22:04
[WIP] fix condition when target shouldn't build, but target_folder not exists
@jaximan
Copy link

jaximan commented Jun 11, 2019

Good day @leavez
I'm wondering, if you could review changes or assign someone?

@acecilia
Copy link

What is needed for this PR to move forward?

@isnine
Copy link

isnine commented Nov 13, 2019

@Rag0n Hello,I like this feature very much, but I tried it and there seems to be some problems

NoMethodError - undefined methodhas_local_cache_for' for Pod::Prebuild::SharedCache:Class
Did you mean? has_local_cache_for?
/Users/nine/work/bytedance/cocoapods-binary/lib/cocoapods-binary/helper/shared_cache.rb:16:in has?'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store frameworks in a shared cache
6 participants