-
Notifications
You must be signed in to change notification settings - Fork 207
Add ability to store prebuilt frameworks in shared cache folder #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank for the new feature implementation. But a fundamental question: How to identify the pod and its generated framework? There may be code in podfile to modify the generated pod targets, and it will lead to different build result. |
I don't understand your point. Could you provide a use case? I mean what do you want to modify in prebuilt framework? Cache is respecting custom build options set via set_custom_xcodebuild_options_for_prebuilt_frameworks. I don't see difference between using cache and not using it, probably I'm missing something. |
I guess case is when Podfile contains |
But cache only works for I would like to have S3 remote cache as well. @jaximan, do you want to implement it by yourself or you need some help? |
@Rag0n I can add it, would you like to have PR for your branch or as separate PR for this master after your change is merged? |
I think PR for this branch will be faster, but it's up to you. |
[WIP] fix condition when target shouldn't build, but target_folder not exists
Add s3 support
Good day @leavez |
What is needed for this PR to move forward? |
@Rag0n Hello,I like this feature very much, but I tried it and there seems to be some problems
|
Resolves #37