-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add support for allowWatchBookmarks to the dynamic client #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for allowWatchBookmarks to the dynamic client #2317
Conversation
There's some evidence in the commit/issue/PR history that people have been managing to enable watch bookmarks. But I'm not sure how this is possible without setting the But in any case, this PR makes it possible. |
/assign @fabianvf |
@fabianvf any comments on this? It's a pretty trivial addition, and I can't see how bookmarks could work without it. |
do you mind to add an example on how it is used? |
The Is this what you had in mind? |
thanks for the PR /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anvilpete, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
There's currently no way to pass
allow_watch_bookmark
to the dynamic client'swatch
method. This PR adds this parameter.the
allowWatchBookmarks
query parameter is currently never set. This PR sets it based on theallow_watch_bookmarks
keyword arg.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: