fix: avoid use of private api getFragments

Closes #97

Author: Kaushik Gopal

app/build.gradle

@@ -21,7 +21,7 @@ ext {
     okhttpVersion = "3.0.1"
     retrofitVersion = "2.0.0"
     sdkVersion = 24
-    supportLibVersion = "24.2.1"
+    supportLibVersion = "25.2.0"
     butterKnifeVersion = '8.5.1'
 }
 

app/src/main/java/com/morihacky/android/rxjava/fragments/RotationPersist1Fragment.java

@@ -1,5 +1,7 @@
 package com.morihacky.android.rxjava.fragments;
 
+import static android.os.Looper.getMainLooper;
+
 import android.os.Bundle;
 import android.os.Handler;
 import android.support.annotation.Nullable;
@@ -11,25 +13,21 @@
 import butterknife.BindView;
 import butterknife.ButterKnife;
 import butterknife.OnClick;
+import butterknife.Unbinder;
 import com.morihacky.android.rxjava.R;
 import com.morihacky.android.rxjava.wiring.LogAdapter;
-
-import butterknife.Unbinder;
 import io.reactivex.Flowable;
 import io.reactivex.disposables.CompositeDisposable;
 import io.reactivex.subscribers.DisposableSubscriber;
 import java.util.ArrayList;
 import java.util.List;
 import timber.log.Timber;
 
-
-import static android.os.Looper.getMainLooper;
-
 public class RotationPersist1Fragment
       extends BaseFragment
       implements RotationPersist1WorkerFragment.IAmYourMaster {
 
-    public static final String FRAG_TAG = RotationPersist1WorkerFragment.class.getName();
+    public static final String TAG = RotationPersist1Fragment.class.toString();
 
     @BindView(R.id.list_threading_log) ListView _logList;
 
@@ -48,11 +46,12 @@ public void startOperationFromWorkerFrag() {
 
         FragmentManager fm = getActivity().getSupportFragmentManager();
         RotationPersist1WorkerFragment frag =
-              (RotationPersist1WorkerFragment) fm.findFragmentByTag(FRAG_TAG);
+              (RotationPersist1WorkerFragment) fm.findFragmentByTag(
+                  RotationPersist1WorkerFragment.TAG);
 
         if (frag == null) {
             frag = new RotationPersist1WorkerFragment();
-            fm.beginTransaction().add(frag, FRAG_TAG).commit();
+            fm.beginTransaction().add(frag, RotationPersist1WorkerFragment.TAG).commit();
         } else {
             Timber.d("Worker frag already spawned");
         }

app/src/main/java/com/morihacky/android/rxjava/fragments/RotationPersist1WorkerFragment.java

@@ -7,13 +7,14 @@
 import io.reactivex.Flowable;
 import io.reactivex.disposables.Disposable;
 import io.reactivex.flowables.ConnectableFlowable;
-import java.util.List;
 import java.util.concurrent.TimeUnit;
 
 public class RotationPersist1WorkerFragment
       extends Fragment {
 
-    private IAmYourMaster _masterFrag;
+  public static final String TAG = RotationPersist1WorkerFragment.class.toString();
+
+  private IAmYourMaster _masterFrag;
     private ConnectableFlowable<Integer> _storedIntsFlowable;
     private Disposable _storedIntsDisposable;
 
@@ -26,14 +27,9 @@ public class RotationPersist1WorkerFragment
     public void onAttach(Context context) {
         super.onAttach(context);
 
-        List<Fragment> frags = ((MainActivity) context)
+      _masterFrag = (RotationPersist1Fragment) ((MainActivity) context)
               .getSupportFragmentManager()
-              .getFragments();
-        for (Fragment f : frags) {
-            if (f instanceof IAmYourMaster) {
-                _masterFrag = (IAmYourMaster) f;
-            }
-        }
+              .findFragmentByTag(RotationPersist1Fragment.TAG);
 
         if (_masterFrag == null) {
             throw new ClassCastException("We did not find a master who can understand us :(");

app/src/main/java/com/morihacky/android/rxjava/fragments/RotationPersist2Fragment.java

@@ -1,5 +1,7 @@
 package com.morihacky.android.rxjava.fragments;
 
+import static android.os.Looper.getMainLooper;
+
 import android.os.Bundle;
 import android.os.Handler;
 import android.support.annotation.Nullable;
@@ -20,14 +22,11 @@
 import java.util.List;
 import timber.log.Timber;
 
-
-import static android.os.Looper.getMainLooper;
-
 public class RotationPersist2Fragment
       extends BaseFragment
       implements RotationPersist2WorkerFragment.IAmYourMaster {
 
-    public static final String FRAG_TAG = RotationPersist2WorkerFragment.class.getName();
+    public static final String TAG = RotationPersist2Fragment.class.toString();
 
     @BindView(R.id.list_threading_log) ListView _logList;
 
@@ -44,13 +43,14 @@ public void startOperationFromWorkerFrag() {
         _adapter.clear();
 
         FragmentManager fm = getActivity().getSupportFragmentManager();
-        RotationPersist2WorkerFragment frag = (RotationPersist2WorkerFragment) fm.findFragmentByTag(FRAG_TAG);
+        RotationPersist2WorkerFragment frag = (RotationPersist2WorkerFragment) fm.findFragmentByTag(
+            RotationPersist2WorkerFragment.TAG);
 
         if (frag == null) {
             frag = new RotationPersist2WorkerFragment();
             fm
                   .beginTransaction()
-                  .add(frag, FRAG_TAG)
+                  .add(frag, RotationPersist2WorkerFragment.TAG)
                   .commit();
         }
         else {

app/src/main/java/com/morihacky/android/rxjava/fragments/RotationPersist2WorkerFragment.java

@@ -6,12 +6,13 @@
 import com.morihacky.android.rxjava.MainActivity;
 import io.reactivex.Flowable;
 import io.reactivex.processors.PublishProcessor;
-import java.util.List;
 import java.util.concurrent.TimeUnit;
 
 public class RotationPersist2WorkerFragment
       extends Fragment {
 
+    public static final String TAG = RotationPersist2WorkerFragment.class.toString();
+
     private PublishProcessor<Integer> _intStream;
     private PublishProcessor<Boolean> _lifeCycleStream;
 
@@ -27,14 +28,9 @@ public class RotationPersist2WorkerFragment
     public void onAttach(Context context) {
         super.onAttach(context);
 
-        List<Fragment> frags = ((MainActivity) context)
-              .getSupportFragmentManager()
-              .getFragments();
-        for (Fragment f : frags) {
-            if (f instanceof IAmYourMaster) {
-                _masterFrag = (IAmYourMaster) f;
-            }
-        }
+        _masterFrag = (RotationPersist2Fragment) ((MainActivity) context)
+            .getSupportFragmentManager().findFragmentByTag(RotationPersist2Fragment.TAG);
+
 
         if (_masterFrag == null) {
             throw new ClassCastException("We did not find a master who can understand us :(");