Skip to content

Overriding fieldset in a decorator isn't rendering inside tabs #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slyadams opened this issue Jul 27, 2016 · 1 comment
Open

Overriding fieldset in a decorator isn't rendering inside tabs #743

slyadams opened this issue Jul 27, 2016 · 1 comment

Comments

@slyadams
Copy link

Expected

I expected that I could override the fieldset add on (or create a new one) and adding to the bootstrap decorator would mean I can customize how fieldsets are rendered (I'm trying to refactor an existing hand rolled form engine so needed to style mine to be as close to the existing as possible).

Actually

I defined it and it worked fine in fields in the form, but when using fieldsets inside tabs, it rendered my new fieldset item and legend, but none of the fields appeared.

Gist/Plunker/Demo

Plunkr showing a fieldset override
Plunkr showing trying a new fieldset definition

@json-schema-form/angular-schema-form-lead

@Anthropic
Copy link
Member

Hi @slyadams fieldset is a core type like string, it has code in the core that manages its behaviour and the child recursion, so to override it would require it to have its own copy of that internal code, not sure why the simpleTransclusion doesn't cover it, I actually thought it would have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants