Refactoring and add node variables to README.md

Author: jimmy16012019

README.md

@@ -19,3 +19,8 @@ In another terminal window, execute
 ```
 npm test
 ```
+
+Node Variables:
+```
+URL=http://www.automationpractice.com
+```

pages/login_page.js

@@ -1,5 +1,3 @@
-import { browser } from "protractor";
-
 const by = protractor.by;
 const until = protractor.ExpectedConditions;
 

stepdefs/hooks.js

@@ -17,8 +17,8 @@ https://github.com/cucumber/cucumber-js/blob/dfbfed94e2cee4fd6b1f91299f7b450b271
 */
 After(async function (scenario) {
 	const world = this;
-	const scenarioFailed = scenario.result.status === Status.FAILED;
-	if (scenarioFailed) {
+	const failed = scenario.result.status === Status.FAILED;
+	if (failed) {
 		return browser.takeScreenshot().then(async function (base64EncodedImage) {
 			return world.attach(Buffer.from(base64EncodedImage.toString(), 'base64'), 'image/png');
 		});

support/report_utils.js

@@ -4,14 +4,14 @@ const date = new Date();
 const day = date.getDate();
 const month = date.getMonth() + 1;
 const year = date.getFullYear();
-const generatedName = `test_report_${day}_${month}_${year}`;
-const directory = `./target/${generatedName}`;
-const jsonFile = `${directory}/${generatedName}.json`;
-const htmlFile = `${directory}/${generatedName}.html`;
+const reportFileName = `test_report_${day}_${month}_${year}`;
+const directory = `./target/${reportFileName}`;
+const jsonFile = `${directory}/${reportFileName}.json`;
+const htmlFile = `${directory}/${reportFileName}.html`;
 
 const createDirectory = function () {
-	const exists = fileSystem.existsSync(directory);
-	if (!exists) {
+	const directoryDoesNotExist = !fileSystem.existsSync(directory);
+	if (directoryDoesNotExist) {
 		fileSystem.mkdirSync(directory);
 		fileSystem.writeFile(jsonFile);
 	}