Skip to content

Commit d75bec8

Browse files
ahviplcharshildarji
authored andcommitted
absMax.py and absMin.py bugs fixed. (TheAlgorithms#624)
1 parent 6a95bf9 commit d75bec8

File tree

3 files changed

+21
-16
lines changed

3 files changed

+21
-16
lines changed

Maths/abs.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
def absVal(num):
22
"""
33
Function to fins absolute value of numbers.
4-
>>>absVal(-5)
4+
>>absVal(-5)
55
5
6-
>>>absVal(0)
6+
>>absVal(0)
77
0
88
"""
99
if num < 0:

Maths/absMax.py

+12-7
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,27 @@
1-
from abs import absVal
1+
from Maths.abs import absVal
2+
23
def absMax(x):
34
"""
4-
>>>absMax([0,5,1,11])
5+
#>>>absMax([0,5,1,11])
56
11
67
>>absMax([3,-10,-2])
78
-10
89
"""
9-
j = x[0]
10+
j =x[0]
1011
for i in x:
11-
if absVal(i) < j:
12+
if absVal(i) > absVal(j):
1213
j = i
1314
return j
1415
#BUG: i is apparently a list, TypeError: '<' not supported between instances of 'list' and 'int' in absVal
15-
16+
#BUG fix
1617

1718
def main():
18-
a = [1,2,-11]
19-
print(absVal(a)) # = -11
19+
a = [-13, 2, -11, -12]
20+
print(absMax(a)) # = -13
2021

2122
if __name__ == '__main__':
2223
main()
24+
25+
"""
26+
print abs Max
27+
"""

Maths/absMin.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
1-
from abs import absVal
1+
from Maths.abs import absVal
22
def absMin(x):
33
"""
4-
>>>absMin([0,5,1,11])
4+
# >>>absMin([0,5,1,11])
55
0
6-
>>absMin([3,-10,-2])
6+
# >>absMin([3,-10,-2])
77
-2
88
"""
9-
j = absVal(x[0])
9+
j = x[0]
1010
for i in x:
11-
if absVal(i) < j:
11+
if absVal(i) < absVal(j):
1212
j = i
1313
return j
1414

1515
def main():
16-
a = [1,2,-11]
17-
print(absMin(a)) # = 1
16+
a = [-3,-1,2,-11]
17+
print(absMin(a)) # = -1
1818

1919
if __name__ == '__main__':
2020
main()

0 commit comments

Comments
 (0)