Skip to content

Commit f59f274

Browse files
committed
improvements on post execution control
1 parent 134dd05 commit f59f274

File tree

4 files changed

+18
-27
lines changed

4 files changed

+18
-27
lines changed

operator-framework/src/main/java/io/javaoperatorsdk/operator/processing/DefaultEventHandler.java

-2
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ void eventProcessingFinished(ExecutionScope executionScope, PostExecutionControl
8686
lock.lock();
8787
log.debug("Event processing finished. Scope: {}", executionScope);
8888
unsetUnderExecution(executionScope.getCustomResourceUid());
89-
defaultEventSourceManager.controllerExecuted(
90-
new ExecutionDescriptor(executionScope, postExecutionControl, LocalDateTime.now()));
9189
if (containsCustomResourceDeletedEvent(executionScope.getEvents())) {
9290
cleanupAfterDeletedEvent(executionScope.getCustomResourceUid());
9391
} else {
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,36 @@
11
package io.javaoperatorsdk.operator.processing;
22

3+
import io.javaoperatorsdk.operator.api.UpdateControl;
4+
5+
import java.util.Optional;
6+
37
public final class PostExecutionControl {
48

59
private final boolean onlyFinalizerHandled;
610

7-
private PostExecutionControl(boolean onlyFinalizerHandled) {
11+
private final UpdateControl updateControl;
12+
13+
private PostExecutionControl(boolean onlyFinalizerHandled, UpdateControl updateControl) {
814
this.onlyFinalizerHandled = onlyFinalizerHandled;
15+
this.updateControl = updateControl;
916
}
1017

1118
public static PostExecutionControl onlyFinalizerAdded() {
12-
return new PostExecutionControl(true);
19+
return new PostExecutionControl(true,null);
1320
}
1421

1522
public static PostExecutionControl defaultDispatch() {
16-
return new PostExecutionControl(false);
23+
return new PostExecutionControl(false,null);
24+
}
25+
public static PostExecutionControl dispatchWithUpdateControl(UpdateControl updateControl) {
26+
return new PostExecutionControl(false,updateControl);
1727
}
1828

1929
public boolean isOnlyFinalizerHandled() {
2030
return onlyFinalizerHandled;
2131
}
32+
33+
public Optional<UpdateControl> getUpdateControl() {
34+
return Optional.ofNullable(updateControl);
35+
}
2236
}

operator-framework/src/main/java/io/javaoperatorsdk/operator/processing/event/DefaultEventSourceManager.java

-5
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,6 @@ public Map<String, EventSource> getRegisteredEventSources() {
6565
return Collections.unmodifiableMap(eventSources);
6666
}
6767

68-
public void controllerExecuted(ExecutionDescriptor executionDescriptor) {
69-
String uid = executionDescriptor.getExecutionScope().getCustomResourceUid();
70-
Map<String, EventSource> sources = getRegisteredEventSources();
71-
}
72-
7368
public void cleanup(String customResourceUid) {
7469
getRegisteredEventSources().keySet().forEach(k -> deRegisterCustomResourceFromEventSource(k,customResourceUid));
7570
eventSources.remove(customResourceUid);

operator-framework/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEvent.java

+1-17
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,13 @@ public class CustomResourceEvent extends AbstractEvent<CustomResourceEventSource
1010
private final Watcher.Action action;
1111
private final CustomResource customResource;
1212

13-
private int retryCount = -1;
14-
private boolean processRegardlessOfGeneration = false;
15-
1613
public CustomResourceEvent(Watcher.Action action, CustomResource resource,
1714
CustomResourceEventSource customResourceEventSource) {
1815
super(KubernetesResourceUtils.getUID(resource), customResourceEventSource);
1916
this.action = action;
2017
this.customResource = resource;
2118
}
2219

23-
public boolean isProcessRegardlessOfGeneration() {
24-
return processRegardlessOfGeneration;
25-
}
26-
27-
public void setProcessRegardlessOfGeneration(boolean processRegardlessOfGeneration) {
28-
this.processRegardlessOfGeneration = processRegardlessOfGeneration;
29-
}
30-
3120
public Watcher.Action getAction() {
3221
return action;
3322
}
@@ -44,12 +33,7 @@ public String toString() {
4433
", apiVersion=" + getCustomResource().getApiVersion() + " ,resourceVersion=" + getCustomResource().getMetadata().getResourceVersion() +
4534
", markedForDeletion: " + (getCustomResource().getMetadata().getDeletionTimestamp() != null
4635
&& !getCustomResource().getMetadata().getDeletionTimestamp().isEmpty()) +
47-
" ], retriesIndex=" + retryCount +
48-
'}';
49-
}
50-
51-
public int getRetryCount() {
52-
return retryCount;
36+
" ]}";
5337
}
5438

5539
public CustomResource getCustomResource() {

0 commit comments

Comments
 (0)