fix(quarkus): use constructor injection instead of @Inject

Author: geoand

operator-framework-quarkus-extension/runtime/src/main/java/io/javaoperatorsdk/quarkus/extension/ConfigurationServiceRecorder.java

@@ -1,7 +1,9 @@
 package io.javaoperatorsdk.quarkus.extension;
 
+import io.fabric8.kubernetes.client.KubernetesClient;
 import io.javaoperatorsdk.operator.api.config.ConfigurationService;
 import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
+import io.quarkus.arc.Arc;
 import io.quarkus.runtime.annotations.Recorder;
 import java.util.List;
 import java.util.function.Supplier;
@@ -11,6 +13,8 @@ public class ConfigurationServiceRecorder {
 
   public Supplier<ConfigurationService> configurationServiceSupplier(
       List<ControllerConfiguration> controllerConfigs) {
-    return () -> new QuarkusConfigurationService(controllerConfigs);
+    return () ->
+        new QuarkusConfigurationService(
+            controllerConfigs, Arc.container().instance(KubernetesClient.class).get());
   }
 }

operator-framework-quarkus-extension/runtime/src/main/java/io/javaoperatorsdk/quarkus/extension/OperatorProducer.java

@@ -8,18 +8,18 @@
 import io.quarkus.arc.DefaultBean;
 import javax.enterprise.inject.Instance;
 import javax.enterprise.inject.Produces;
-import javax.inject.Inject;
 import javax.inject.Singleton;
 
 @Singleton
 public class OperatorProducer {
 
-  @Inject Instance<ResourceController<? extends CustomResource>> controllers;
-
   @Produces
   @DefaultBean
   @Singleton
-  Operator operator(KubernetesClient client, ConfigurationService configuration) {
+  Operator operator(
+      KubernetesClient client,
+      ConfigurationService configuration,
+      Instance<ResourceController<? extends CustomResource>> controllers) {
     final var operator = new Operator(client, configuration);
     controllers.stream().forEach(operator::register);
     return operator;

operator-framework-quarkus-extension/runtime/src/main/java/io/javaoperatorsdk/quarkus/extension/QuarkusConfigurationService.java

@@ -8,13 +8,14 @@
 import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
 import io.quarkus.arc.runtime.ClientProxyUnwrapper;
 import java.util.List;
-import javax.inject.Inject;
 
 public class QuarkusConfigurationService extends AbstractConfigurationService {
-  @Inject KubernetesClient client;
   private static final ClientProxyUnwrapper unwrapper = new ClientProxyUnwrapper();
+  private final KubernetesClient client;
 
-  public QuarkusConfigurationService(List<ControllerConfiguration> configurations) {
+  public QuarkusConfigurationService(
+      List<ControllerConfiguration> configurations, KubernetesClient client) {
+    this.client = client;
     if (configurations != null && !configurations.isEmpty()) {
       configurations.forEach(this::register);
     }