-
Notifications
You must be signed in to change notification settings - Fork 40
Implement out-of-repo installation #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To separate sources and binaries, we are using a binary distibution which contains only required files. The pull request contains lots of cosmetic changes which likely not required to achieve your goal. I agree to add additional installation script and minimal changes required for it. No CMakeFiles in icsc, sc_elab, sc_tools can be changed as they work in multiple environments. |
Ok, the install script does not really depend on the other changes. Looking into the cmake files, I notice that they depend on ENV{ICSC_HOME} in places where it would be natural to use CMAKE_CURRENT_SOURCE_DIR, for example. The cmake system keeps track of its location. Most of the "cosmetic" changes served to remove this environment dependency. The result was, in my oppinion, a more "proper" cmake configuration flow where the user is not required to source setenv.sh before building. VSCode cmake tools integration is one example. |
That looks good, just a few notes:
|
|
Thank you. Probably will move INSTALL2.md into the wiki page in some future. |
Please update the |
Updated install2.sh with LLVM (15.0.7), with upgrades to GDB and protobuf. |
I do not see updated files. |
In some environments, the system admin may require the installed files to be separate from the source code.
The added install2.sh script allows one to set the install prefix, as well as specifying per-package CMAKE_BUILD_TYPE.
I really want to use icsc at my work site, but it require some changes. The first one being to separate the binaries and the source code.