Fix 1000+ lint errors

Author: grant

.eslintignore

@@ -0,0 +1 @@
+moment.gs

.eslintrc.js

@@ -1,7 +1,7 @@
 module.exports = {
     "extends": "google",
     "parserOptions": {
-        "ecmaVersion": 3,
+        "ecmaVersion": 6,
     },
     "env": {
         "node": true,
@@ -11,8 +11,9 @@ module.exports = {
         "camelcase": "off", // Off for destructuring
         "async-await/space-after-async": 2,
         "async-await/space-after-await": 2,
+        "guard-for-in": "off",
         "no-var": "off", // ES3
         "no-unused-vars": "off" // functions aren't used.
     },
-    "plugins": ["async-await"],
+    "plugins": ["async-await"]
 };

adminSDK/directory/quickstart.gs

@@ -14,11 +14,14 @@
  * limitations under the License.
  */
 // [START admin_sdk_directory_quickstart]
+/**
+ * Lists users in a G Suite domain.
+ */
 function listUsers() {
   var optionalArgs = {
     customer: 'my_customer',
     maxResults: 10,
-    orderBy: 'email'
+    orderBy: 'email',
   };
   var response = AdminDirectory.Users.list(optionalArgs);
   var users = response.users;

adminSDK/reports/quickstart.gs

@@ -14,13 +14,16 @@
  * limitations under the License.
  */
 // [START admin_sdk_reports_quickstart]
+/**
+ * List login events for a G Suite domain.
+ */
 function listLogins() {
   var userKey = 'all';
   var applicationName = 'login';
   var optionalArgs = {
-    maxResults: 10
+    maxResults: 10,
   };
-  var response = AdminReports.Activities.list(userKey, applicationName, optionalArgs)
+  var response = AdminReports.Activities.list(userKey, applicationName, optionalArgs);
   var activities = response.items;
   if (activities && activities.length > 0) {
     Logger.log('Logins:');

adminSDK/reseller/quickstart.gs

@@ -14,9 +14,12 @@
  * limitations under the License.
  */
 // [START admin_sdk_reseller_quickstart]
+/**
+ * List Admin SDK reseller subscriptions.
+ */
 function listSubscriptions() {
   var optionalArgs = {
-    maxResults: 10
+    maxResults: 10,
   };
   var response = AdminReseller.Subscriptions.list(optionalArgs);
   var subscriptions = response.subscriptions;

android/mobile-translate/Code.gs

@@ -96,12 +96,12 @@ function getSelectedText() {
         }
       }
     }
-    if (text.length == 0) {
-      throw 'Please select some text.';
+    if (text.length) {
+      throw new Error('Please select some text.');
     }
     return text;
   } else {
-    throw 'Please select some text.';
+    throw new Error('Please select some text.');
   }
 }
 
@@ -118,7 +118,7 @@ function getPreferences() {
   var userProperties = PropertiesService.getUserProperties();
   var languagePrefs = {
     originLang: userProperties.getProperty('originLang'),
-    destLang: userProperties.getProperty('destLang')
+    destLang: userProperties.getProperty('destLang'),
   };
   return languagePrefs;
 }
@@ -170,7 +170,7 @@ function insertText(newText) {
     if (elements.length == 1 &&
         elements[0].getElement().getType() ==
         DocumentApp.ElementType.INLINE_IMAGE) {
-      throw "Can't insert text into an image.";
+      throw new Error('Can\'t insert text into an image.');
     }
     for (var i = 0; i < elements.length; i++) {
       if (elements[i].isPartial()) {

calendar/quickstart/quickstart.gs

@@ -24,7 +24,7 @@ function listUpcomingEvents() {
     showDeleted: false,
     singleEvents: true,
     maxResults: 10,
-    orderBy: 'startTime'
+    orderBy: 'startTime',
   };
   var response = Calendar.Events.list(calendarId, optionalArgs);
   var events = response.items;

calendar/vacationCalendar/vacationCalendar.gs

@@ -54,7 +54,7 @@ function syncTeamVacationCalendar() {
       events.forEach(function(event) {
         event.summary = '[' + username + '] ' + event.summary;
         event.organizer = {
-          id: TEAM_CALENDAR_ID
+          id: TEAM_CALENDAR_ID,
         };
         event.attendees = [];
         Logger.log('Importing: %s', event.summary);
@@ -74,26 +74,26 @@ function syncTeamVacationCalendar() {
     Logger.log('Execution time about to hit quota limit; execution stopped.');
   }
   var executionTime = ((new Date()).getTime() - today.getTime()) / 1000.0;
-  Logger.log('Total execution time (s) : ' + executionTime);;
+  Logger.log('Total execution time (s) : ' + executionTime); ;
 }
 
 /**
  * In a given user's calendar, look for occurrences of the given keyword
  * in events within the specified date range and return any such events
  * found.
- * @param user the user's primary email String.
- * @param keyword the keyword String to look for.
- * @param start the starting Date of the range to examine.
- * @param end the ending Date of the range to examine.
- * @param opt_since a Date indicating the last time this script was run.
- * @return an array of calendar event Objects.
+ * @param {string} user the user's primary email String.
+ * @param {string} keyword the keyword String to look for.
+ * @param {Date} start the starting Date of the range to examine.
+ * @param {Date} end the ending Date of the range to examine.
+ * @param {Date} opt_since a Date indicating the last time this script was run.
+ * @return {object[]} an array of calendar event Objects.
  */
 function findEvents(user, keyword, start, end, opt_since) {
   var params = {
     q: keyword,
     timeMin: formatDate(start),
     timeMax: formatDate(end),
-    showDeleted: true
+    showDeleted: true,
   };
   if (opt_since) {
     // This prevents the script from examining events that have not been
@@ -134,18 +134,19 @@ function findEvents(user, keyword, start, end, opt_since) {
 
 /**
  * Return a list of the primary emails of users in this domain.
- * @return array of user email Strings.
+ * @return {string[]} An array of user email strings.
  */
 function getDomainUsers() {
-  var pageToken, page;
+  var pageToken;
+  var page;
   var userEmails = [];
   do {
     page = AdminDirectory.Users.list({
       customer: 'my_customer',
       orderBy: 'givenName',
       maxResults: 100,
       pageToken: pageToken,
-      viewType: 'domain_public'
+      viewType: 'domain_public',
     });
     var users = page.users;
     if (users) {
@@ -163,8 +164,8 @@ function getDomainUsers() {
 /**
  * Return an RFC3339 formated date String corresponding to the given
  * Date object.
- * @param date a Date.
- * @return a formatted date string.
+ * @param {Date} date a Date.
+ * @return {string} a formatted date string.
  */
 function formatDate(date) {
   return Utilities.formatDate(date, 'UTC', 'yyyy-MM-dd\'T\'HH:mm:ssZ');
@@ -174,9 +175,9 @@ function formatDate(date) {
  * Compares two Date objects and returns true if the difference
  * between them is more than the maximum specified run time.
  *
- * @param start the first Date object.
- * @param now the (later) Date object.
- * @returns true if the time difference is greater than
+ * @param {Date} start the first Date object.
+ * @param {Date} now the (later) Date object.
+ * @return {boolean} true if the time difference is greater than
  *     MAX_PROP_RUNTIME_MS (in milliseconds).
  */
 function isTimeUp(start, now) {

classroom/quickstart/quickstart.gs

@@ -19,7 +19,7 @@
  */
 function listCourses() {
   var optionalArgs = {
-    pageSize: 10
+    pageSize: 10,
   };
   var response = Classroom.Courses.list(optionalArgs);
   var courses = response.courses;

docs/cursorInspector/cursorInspector.gs

@@ -55,7 +55,7 @@ function getDocumentInfo() {
       element: getElementInfo(cursor.getElement()),
       offset: cursor.getOffset(),
       surroundingText: cursor.getSurroundingText().getText(),
-      surroundingTextOffset: cursor.getSurroundingTextOffset()
+      surroundingTextOffset: cursor.getSurroundingTextOffset(),
     };
   }
   if (selection) {
@@ -65,10 +65,10 @@ function getDocumentInfo() {
           element: getElementInfo(selectedElement.getElement()),
           partial: selectedElement.isPartial(),
           startOffset: selectedElement.getStartOffset(),
-          endOffsetInclusive: selectedElement.getEndOffsetInclusive()
-        }
-      })
-    }
+          endOffsetInclusive: selectedElement.getEndOffsetInclusive(),
+        };
+      }),
+    };
   }
   return result;
 }

docs/dialog2sidebar/Code.gs

@@ -36,6 +36,7 @@ function showSidebar() {
 
 /**
  * Open a dialog in the document.
+ * @return {string} The dialog ID.
  */
 function openDialog() {
   var dialogId = Utilities.base64Encode(Math.random());
@@ -50,6 +51,8 @@ function openDialog() {
 
 /**
  * Include the contents of the given file into the HTML content.
+ * @param {string} filename The filename
+ * @return {string} The content of the rendered file.
  */
 function include(filename) {
   return HtmlService.createHtmlOutputFromFile(filename).getContent();

docs/translate/translate.gs

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
+// [START docs_translate_quickstart]
 /**
  * @OnlyCurrentDoc
  *
@@ -98,11 +98,11 @@ function getSelectedText() {
       }
     }
     if (!text.length) {
-      throw 'Please select some text.';
+      throw new Error('Please select some text.');
     }
     return text;
   } else {
-    throw 'Please select some text.';
+    throw new Error('Please select some text.');
   }
 }
 
@@ -119,7 +119,7 @@ function getPreferences() {
   var userProperties = PropertiesService.getUserProperties();
   return {
     originLang: userProperties.getProperty('originLang'),
-    destLang: userProperties.getProperty('destLang')
+    destLang: userProperties.getProperty('destLang'),
   };
 }
 
@@ -146,7 +146,7 @@ function getTextAndTranslation(origin, dest, savePrefs) {
   var text = getSelectedText().join('\n');
   return {
     text: text,
-    translation: translateText(text, origin, dest)
+    translation: translateText(text, origin, dest),
   };
 }
 
@@ -166,7 +166,7 @@ function insertText(newText) {
     var elements = selection.getSelectedElements();
     if (elements.length === 1 && elements[0].getElement().getType() ===
         DocumentApp.ElementType.INLINE_IMAGE) {
-      throw "Can't insert text into an image.";
+      throw new Error('Can\'t insert text into an image.');
     }
     for (var i = 0; i < elements.length; ++i) {
       if (elements[i].isPartial()) {
@@ -250,3 +250,4 @@ function translateText(text, origin, dest) {
   if (origin === dest) return text;
   return LanguageApp.translate(text, origin, dest);
 }
+// [END docs_translate_quickstart]

drive/activity/quickstart.gs

@@ -14,11 +14,14 @@
  * limitations under the License.
  */
 // [START drive_activity_quickstart]
+/**
+ * Lists activity for a Drive user.
+ */
 function listActivity() {
   var optionalArgs = {
-    source: 'drive.google.com',
+    'source': 'drive.google.com',
     'drive.ancestorId': 'root',
-    pageSize: 10
+    'pageSize': 10,
   };
   var response = AppsActivity.Activities.list(optionalArgs);
   var activities = response.activities;

drive/quickstart/quickstart.gs

@@ -19,8 +19,8 @@
  */
 function listFiles() {
   var files = Drive.Files.list({
-    fields: "nextPageToken, files(id, name)",
-    pageSize: 10
+    fields: 'nextPageToken, files(id, name)',
+    pageSize: 10,
   }).files;
   for (var i = 0; i < files.length; i++) {
     var file = files[i];