Apply suggestions from code review

methane · web-flow · commit e22950891d71 · 2025-04-22T20:59:01.000+09:00
diff --git a/benchmark_test.go b/benchmark_test.go
@@ -129,13 +129,13 @@ func BenchmarkSelect10000rows(b *testing.B) {
 		return
 	}
 
-	b.StartTimer()
+	b.ResetTimer()
 	stmt, err := db.Prepare("SELECT * FROM seq_1_to_10000")
 	if err != nil {
 		b.Fatalf("Failed to prepare statement: %v", err)
 	}
 	defer stmt.Close()
-	for n := 0; n < b.N; n++ {
+	for range b.N {
 		rows, err := stmt.Query()
 		if err != nil {
 			b.Fatalf("Failed to query 10000rows: %v", err)
@@ -151,7 +151,6 @@ func BenchmarkSelect10000rows(b *testing.B) {
 		}
 		rows.Close()
 	}
-	b.StopTimer()
 }
 
 func BenchmarkExec(b *testing.B) {

Original file line number	Diff line number	Diff line change
`@@ -129,13 +129,13 @@ func BenchmarkSelect10000rows(b *testing.B) {`
`129`	`129`	`return`
`130`	`130`	`}`
`131`	`131`
`132`		`- b.StartTimer()`
	`132`	`+ b.ResetTimer()`
`133`	`133`	`stmt, err := db.Prepare("SELECT * FROM seq_1_to_10000")`
`134`	`134`	`if err != nil {`
`135`	`135`	`b.Fatalf("Failed to prepare statement: %v", err)`
`136`	`136`	`}`
`137`	`137`	`defer stmt.Close()`
`138`		`- for n := 0; n < b.N; n++ {`
	`138`	`+ for range b.N {`
`139`	`139`	`rows, err := stmt.Query()`
`140`	`140`	`if err != nil {`
`141`	`141`	`b.Fatalf("Failed to query 10000rows: %v", err)`
`@@ -151,7 +151,6 @@ func BenchmarkSelect10000rows(b *testing.B) {`
`151`	`151`	`}`
`152`	`152`	`rows.Close()`
`153`	`153`	`}`
`154`		`- b.StopTimer()`
`155`	`154`	`}`
`156`	`155`
`157`	`156`	`func BenchmarkExec(b *testing.B) {`