Add Automatic-Module-Name manifest entry #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of warnings on Java 9+, and makes it safer to use this library as a module.
|
The CI error is unrelated with this change. We need to merge #970 or an equivalent solution |
jmini
reviewed
May 4, 2023
pom.xml
Outdated
| @@ -171,6 +171,9 @@ | |||
| <configuration> | |||
| <archive> | |||
| <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile> | |||
| <manifestEntries> | |||
| <Automatic-Module-Name>org.gitlab4j</Automatic-Module-Name> | |||
There was a problem hiding this comment.
Where is the best practice definition for automatic-module-names?
since our groupId is: org.gitlab4j
and our artifactId is: gitlab4j-api
I am wondering if it wouldn't be better to name this module org.gitlab4j.api.
There was a problem hiding this comment.
I don't know. Your suggestion org.gitlab4j.api absolutely sounds reasonable.
There was a problem hiding this comment.
@jabby do you have an opinion?
There was a problem hiding this comment.
I think org.gitlab4j.api is a good idea.
There was a problem hiding this comment.
I think
org.gitlab4j.apiis a good idea.
Updated to org.gitlab4j.api.
jmini
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of warnings on Java 9+, and makes it safer to use this library as a module.