Skip to content

Change User representation in Webhooks #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

jmini
Copy link
Collaborator

@jmini jmini commented Apr 13, 2023

Fixes #927

The User representation in the Webhooks event is:

{
    "id": 1,
    "name": "Administrator",
    "username": "root",
    "avatar_url": "http://www.gravatar.com/avatar/e64c7d89f26bd1972efa854d13d7dd61?s=40\u0026d=identicon",
    "email": "admin@example.com"
}

Documentation: https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html

This PR introduce a new type EventUser for this simplified representation of User.

Since 6.0.0 is a new major version, I think it is fine to do this breaking change.

All the deserialization tests continue to pass.

@jabby jabby merged commit 5d06164 into gitlab4j:6.x Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants