Skip to content

build: Use rolldown for bundles #16119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 23, 2025

This PR changes to use Rolldown to build the browser bundles. We can't use it for any other SDK builds yet because it doesn't support preserveModules.

The strict and treeshake config changes are due to minor changes in the Rollup config.

Copy link
Contributor

github-actions bot commented Apr 23, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.28 KB - -
@sentry/browser - with treeshaking flags 23.12 KB - -
@sentry/browser (incl. Tracing) 36.99 KB - -
@sentry/browser (incl. Tracing, Replay) 74.17 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.55 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 78.83 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 90.65 KB - -
@sentry/browser (incl. Feedback) 39.68 KB - -
@sentry/browser (incl. sendFeedback) 27.9 KB - -
@sentry/browser (incl. FeedbackAsync) 32.67 KB - -
@sentry/react 25.09 KB - -
@sentry/react (incl. Tracing) 38.91 KB - -
@sentry/vue 27.51 KB - -
@sentry/vue (incl. Tracing) 38.71 KB - -
@sentry/svelte 23.32 KB - -
⛔️ CDN Bundle (max: 25.39 KB) 25.68 KB +4.83% +1.18 KB 🔺
⛔️ CDN Bundle (incl. Tracing) (max: 38.09 KB) 39.06 KB +5.63% +2.08 KB 🔺
CDN Bundle (incl. Tracing, Replay) 75.31 KB +4.6% +3.31 KB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 83.9 KB +8.74% +6.74 KB 🔺
CDN Bundle - uncompressed 74.76 KB +4.58% +3.27 KB 🔺
CDN Bundle (incl. Tracing) - uncompressed 115.06 KB +5.23% +5.71 KB 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 229.91 KB +4.21% +9.28 KB 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 251.34 KB +7.8% +18.17 KB 🔺
@sentry/nextjs (client) 40.54 KB - -
@sentry/sveltekit (client) 37.44 KB - -
@sentry/node 143.37 KB - -
@sentry/node - without tracing 96.51 KB - -
@sentry/aws-serverless 120.83 KB - -

View base workflow run

@timfish
Copy link
Collaborator Author

timfish commented Apr 23, 2025

@AbhiPrasad, it looks like the tree shaking can't match Rollup and the replay bundles fail the es-check linting 😭

Let me know if you want me to spend more time on this!

@timfish timfish closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant