-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[JavaScript] React Router (v7) SDK #14519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hey, im coming from Remix - used @sentry/remix before, but after upgrading to RRv7 there are dependencies which cant be there "react-router-dom" from some remix packages - so would be nice, if the new implementation will also work from former @sentry/remix users. BR |
This probably needs to be a new package, and we also need to write out migration docs about how to go from |
This comment has been minimized.
This comment has been minimized.
Anything I can do to help you guys? |
@AlemTuzlak Not yet, we'll refine this ticket as soon as possible and provide a more detailed roadmap. |
For others finding this before the full v7 framework support is available, here's the guide on how to get it working with the react and node integrations: https://docs.sentry.io/platforms/javascript/guides/react-router/. It was a bit hard for me to find, so sharing here. |
Hi @chargome! I haven't miss revealing. What I meant is that RR7 Framework doesn't use those files (like Remix does). |
@denissisic yes it does, and they can be revealed, by default they use the internal default entry.client and entry.server files which you can reveal if you need to make changes to them. |
At least the framework mode of react-router v7, library indeed doesn't |
@denissisic the framework does use these files: https://reactrouter.com/explanation/special-files#entryservertsx Would you mind creating a separate issue with a reproduction so we can investigate what is causing the problem? |
Hey guys! Sorry for jumping to wrong conclusions due to misunderstanding on my part. It seems that all works now. |
@chargome I saw @mydea removed many of the instrumentation todo's from the milestone what does this mean for the stable SDK release? |
@gijsroge that was just some internal restructuring, we're still actively working towards a stable release atm |
Description
This ticket is about supporting React Router v7 as a full meta-framework: https://reactrouter.com/start/framework/installation
This includes full instrumentation for both client and server side.
Overview
We will publish a new package
@sentry/react-router
.To not carry over too much unneeded functionality like rsbuild support, non-otel instrumentation or support for older remix versions we will not build upon
@sentry/remix
and rather treat this as new SDK with the possibility of re-using remix otel instrumentation.The starting point will be instrumenting the framework using
@sentry/node
and@sentry/react
Discussed approach for configuration and entrypoints:
Additional tasks (issue creation tbd)
@sentry/remix
to@sentry/react-router
@sentry/react-router
The text was updated successfully, but these errors were encountered: