Use for/in instead of forEach on Object.keys

Because `Object.keys` doesn't enumerate keys all the way
up the prototype chain, this was causing bugs when used
with `Vue.extend`.

Author: foxbenjaminfox

CHANGELOG.md

@@ -2,6 +2,7 @@
 <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
 # Changelog
 
+- [v3.1.1](#v311)
 - [v3.1.0](#v310)
 - [v3.0.1](#v301)
 - [v3.0.0](#v300)
@@ -15,6 +16,10 @@
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
 
+### v3.1.1
+  * Fix bug where `vue-async-computed` wouldn't find async computed
+    properties that were further up the prototype chain.
+
 ### v3.1.0
   * Add option for setting a global default value
   * Improve test coverage

src/index.js

@@ -14,28 +14,28 @@ const AsyncComputed = {
 
         if (!this.$options.computed) this.$options.computed = {}
 
-        Object.keys(this.$options.asyncComputed || {}).forEach(key => {
+        for (const key in this.$options.asyncComputed || {}) {
           this.$options.computed[prefix + key] = getterFor(this.$options.asyncComputed[key])
-        })
+        }
 
         this.$options.data = function vueAsyncComputedInjectedDataFn () {
           const data = (
               (typeof optionData === 'function')
                 ? optionData.call(this)
                 : optionData
              ) || {}
-          Object.keys(this.$options.asyncComputed || {}).forEach(key => {
+          for (const key in this.$options.asyncComputed || {}) {
             data[key] = null
-          })
+          }
           return data
         }
       },
       created () {
-        Object.keys(this.$options.asyncComputed || {}).forEach(key => {
+        for (const key in this.$options.asyncComputed || {}) {
           this[key] = defaultFor.call(this, this.$options.asyncComputed[key], pluginOptions)
-        })
+        }
 
-        Object.keys(this.$options.asyncComputed || {}).forEach(key => {
+        for (const key in this.$options.asyncComputed || {}) {
           let promiseId = 0
           this.$watch(prefix + key, newPromise => {
             const thisPromise = ++promiseId
@@ -63,7 +63,7 @@ const AsyncComputed = {
               }
             })
           }, { immediate: true })
-        })
+        }
       }
     })
   }

test/index.js

@@ -396,3 +396,20 @@ test("Handle an async computed value returning synchronously", t => {
     t.equal(vm.x, 1)
   })
 })
+
+test("Work correctly with Vue.extend", t => {
+  t.plan(2)
+  const SubVue = Vue.extend({
+    asyncComputed: {
+      async x () {
+        return 1
+      }
+    }
+  })
+  const vm = new SubVue({})
+
+  t.equal(vm.x, null)
+  Vue.nextTick(() => {
+    t.equal(vm.x, 1)
+  })
+})