Renamed a variable to better represent what is happening in the balance after insert method

Justin Wetherell · Justin Wetherell · commit 5756bc91fa82 · 2015-09-09T09:41:36.000-04:00
diff --git a/src/com/jwetherell/algorithms/data_structures/AVLTree.java b/src/com/jwetherell/algorithms/data_structures/AVLTree.java
@@ -81,18 +81,18 @@ protected Node<T> addValue(T id) {
     private void balanceAfterInsert(AVLNode<T> node) {
         int balanceFactor = node.getBalanceFactor();
         if (balanceFactor > 1 || balanceFactor < -1) {
-            AVLNode<T> parent = (AVLNode<T>) node.parent;
+            AVLNode<T> child = null;
             Balance balance = null;
             if (balanceFactor < 0) {
-                parent = (AVLNode<T>) node.lesser;
-                balanceFactor = parent.getBalanceFactor();
+                child = (AVLNode<T>) node.lesser;
+                balanceFactor = child.getBalanceFactor();
                 if (balanceFactor < 0)
                     balance = Balance.LEFT_LEFT;
                 else 
                     balance = Balance.LEFT_RIGHT;
             } else {
-                parent = (AVLNode<T>) node.greater;
-                balanceFactor = parent.getBalanceFactor();
+                child = (AVLNode<T>) node.greater;
+                balanceFactor = child.getBalanceFactor();
                 if (balanceFactor < 0)
                     balance = Balance.RIGHT_LEFT;
                 else
@@ -101,11 +101,11 @@ private void balanceAfterInsert(AVLNode<T> node) {
 
             if (balance == Balance.LEFT_RIGHT) {
                 // Left-Right (Left rotation, right rotation)
-                rotateLeft(parent);
+                rotateLeft(child);
                 rotateRight(node);
             } else if (balance == Balance.RIGHT_LEFT) {
                 // Right-Left (Right rotation, left rotation)
-                rotateRight(parent);
+                rotateRight(child);
                 rotateLeft(node);
             } else if (balance == Balance.LEFT_LEFT) {
                 // Left-Left (Right rotation)
@@ -115,8 +115,8 @@ private void balanceAfterInsert(AVLNode<T> node) {
                 rotateLeft(node);
             }
 
+            child.updateHeight();
             node.updateHeight();
-            parent.updateHeight();
         }
     }
 
