Skip to content

Commit a8d3c88

Browse files
committed
- improve log message
1 parent 43059c1 commit a8d3c88

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

operator-framework/src/main/java/com/github/containersolutions/operator/processing/EventDispatcher.java

+1
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public void handleEvent(CustomResourceEvent event) {
4444
return;
4545
}
4646
if (markedForDeletion(resource) && !ControllerUtils.hasDefaultFinalizer(resource, resourceDefaultFinalizer)) {
47+
log.debug("Skipping event dispatching since its marked for deletion but has no default finalizer: {}", event);
4748
return;
4849
}
4950
Context context = new DefaultContext(new RetryInfo(event.getRetryCount(), event.getRetryExecution().isLastExecution()));

operator-framework/src/test/java/com/github/containersolutions/operator/sample/TestCustomResourceController.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,12 @@ public TestCustomResourceController(KubernetesClient kubernetesClient, boolean u
4343
public boolean deleteResource(TestCustomResource resource, Context<TestCustomResource> context) {
4444
Boolean delete = kubernetesClient.configMaps().inNamespace(resource.getMetadata().getNamespace())
4545
.withName(resource.getSpec().getConfigMapName()).delete();
46-
if (Boolean.TRUE.equals(delete)) {
46+
if (delete) {
4747
log.info("Deleted ConfigMap {} for resource: {}", resource.getSpec().getConfigMapName(), resource.getMetadata().getName());
48-
return true;
4948
} else {
5049
log.error("Failed to delete ConfigMap {} for resource: {}", resource.getSpec().getConfigMapName(), resource.getMetadata().getName());
51-
return true;
5250
}
51+
return true;
5352
}
5453

5554
@Override

0 commit comments

Comments
 (0)