[compiler][autodeps/fire] Do not include fire functions in autodep arrays #32532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
…rays Summary: We landed on not including fire functions in dep arrays. They aren't needed because all values returned from the useFire hook call will read from the same ref. The linter will error if you include a fired function in an explicit dep array. Test Plan: yarn snap --watch --
mofeiZ
reviewed
Apr 17, 2025
| isSetStateType(dep.identifier)) && | ||
| !reactiveIds.has(dep.identifier.id) | ||
| !reactiveIds.has(dep.identifier.id)) || | ||
| isFireFunctionType(dep.identifier) |
There was a problem hiding this comment.
Ahh makes sense, fire is different than setState / refs in that we always codegen the useFire hook call, so there is no "reactive reference to non-reactive values" issue (e.g. props.cond ? ref1 : ref2)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
…rays (#32532) Summary: We landed on not including fire functions in dep arrays. They aren't needed because all values returned from the useFire hook call will read from the same ref. The linter will error if you include a fired function in an explicit dep array. Test Plan: yarn snap --watch -- DiffTrain build for [b8bedc2](b8bedc2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We landed on not including fire functions in dep arrays. They aren't needed because all values returned from the useFire hook call will read from the same ref. The linter will error if you include a fired function in an explicit dep array.
Test Plan: yarn snap --watch
--