Skip to content

Fix Dockerfile and test docker build in PRs #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Fix Dockerfile and test docker build in PRs #216

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f245824
Use requirements.txt in Dockerfile
lucasssvaz Aug 30, 2024
44160a8
Test docker build in PRs
lucasssvaz Aug 30, 2024
fe7799d
Optimize push workflow for PRs
lucasssvaz Aug 30, 2024
d89b40c
Optimize docker workflow
lucasssvaz Aug 31, 2024
d5f674e
Improve name
lucasssvaz Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Optimize docker workflow
  • Loading branch information
@lucasssvaz
lucasssvaz committed Aug 31, 2024
commit d89b40cf7d7a6a199d8aaaacf08e552893f1de45
9 changes: 4 additions & 5 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ on:
pull_request:
paths:
- ".github/workflows/docker.yml"
- "tools/config_editor/**"
- "tools/docker/**"
- "!**.md"
- "tools/config_editor/requirements.txt"
- "tools/docker/Dockerfile"
- "tools/docker/entrypoint.sh"

env:
# Build the image for amd64 and arm64
Expand All @@ -23,7 +23,7 @@ jobs:
docker:
# Disable the job in forks
if: ${{ github.event_name == 'pull_request' || github.repository_owner == 'espressif' }}

name: Build and push if needed
runs-on: ubuntu-latest
steps:
# Depending on the branch/tag, set CLONE_BRANCH_OR_TAG variable (used in the Dockerfile
Expand Down Expand Up @@ -62,7 +62,6 @@ jobs:
- name: Check variables
run: |
echo "CLONE_BRANCH_OR_TAG: $CLONE_BRANCH_OR_TAG"
echo "CHECKOUT_REF: $CHECKOUT_REF"
echo "TAG_NAME: $TAG_NAME"
echo "URL: $URL"

Expand Down
Loading