Skip to content

Added support for Aventen S3 Sync #8570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Added support for Aventen S3 Sync #8570

wants to merge 4 commits into from

Conversation

avencan
Copy link
Contributor

@avencan avencan commented Aug 27, 2023

Description of Change

Introduced the Aventen-S3-Sync, an custom ESP32-S3 based board.

Tests scenarios

The addition of the board has been tested with various different code and libraries, and we have ensured it will definitely work.

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 28, 2023
P-R-O-C-H-Y
P-R-O-C-H-Y requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avencan Please take a look on my comments.

@VojtechBartoska VojtechBartoska added this to the 2.0.12 milestone Aug 28, 2023
@avencan avencan requested a review from P-R-O-C-H-Y August 28, 2023 15:44
@avencan
Copy link
Contributor Author

avencan commented Aug 28, 2023

Hi @P-R-O-C-H-Y

I have made the changes as requested, aswell as removing some unnecessary things, I hope everything is fine with it now :).

Here's some details about the board - if needed for errors.

image
image

Thanks

@P-R-O-C-H-Y
Copy link
Member

Hi @avencan,

the new commit with changes to boards.txt file is messed up: 24,329 additions, 24,382 deletions so I cannot easily check the changes. Can you try to revert this commit and push the changes again? Thanks

@avencan
Copy link
Contributor Author

avencan commented Aug 29, 2023

Hi @P-R-O-C-H-Y

I don't think I can revert it, and I don't really know why this happened, would you be able to check the changes on a local git client? Sorry about this

Thank you

@P-R-O-C-H-Y
Copy link
Member

Hi @avencan, i will try if that will do good, but first can you please resolve conflicts please? Thanks

@avencan avencan closed this by deleting the head repository Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y Awaiting requested review from P-R-O-C-H-Y

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Resolution: Awaiting response Waiting for response of author Type: 3rd party Boards
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.12
Development

Successfully merging this pull request may close these issues.
4 participants
@avencan @CLAassistant @P-R-O-C-H-Y @VojtechBartoska