Added ESP32-Wrover-Kit with distinct build.board #4118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
added a commit
that referenced
this pull request
Nov 3, 2020
* Added ESP32-Wrover-Kit with distinct build.board * Fixed broken values * Update boards.txt Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
me-no-dev
added a commit
that referenced
this pull request
Mar 31, 2021
* Added ESP32-Wrover-Kit with distinct build.board * Fixed broken values * Update boards.txt Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32_DEVand can't be distinguished from the regular module using#ifdef's during compilation.Creating a separate board with
build.board=ESP32_WROVER_KITsolves that and enables the use of#ifdef ARDUINO_ESP32_WROVER_KITat compilation.Since the Wrover Kit is a development board, all possible menu options are visible.
build.boardproperty value containing dashes instead of underscores