Better use else if, or else the input get's duplicated whilest it is already handled

timkoers · timkoers · commit c344425d3d2e · 2021-01-08T16:32:55.000+01:00
diff --git a/cores/esp32/esp32-hal-uart.c b/cores/esp32/esp32-hal-uart.c
@@ -104,8 +104,7 @@ static void IRAM_ATTR _uart_isr()
             {
                 // Fully optimized code would not create the queue anymore if an function has been specified as an argument.
                 (*uart_interrupt->func)(c, uart_interrupt->user_arg);
-            }
-            if (uart->queue != NULL)
+            }else if (uart->queue != NULL)
             {
                 xQueueSendFromISR(uart->queue, &c, &xHigherPriorityTaskWoken);
             }

Original file line number	Diff line number	Diff line change
`@@ -104,8 +104,7 @@ static void IRAM_ATTR _uart_isr()`
`104`	`104`	`{`
`105`	`105`	`// Fully optimized code would not create the queue anymore if an function has been specified as an argument.`
`106`	`106`	`(*uart_interrupt->func)(c, uart_interrupt->user_arg);`
`107`		`- }`
`108`		`- if (uart->queue != NULL)`
	`107`	`+ }else if (uart->queue != NULL)`
`109`	`108`	`{`
`110`	`109`	`xQueueSendFromISR(uart->queue, &c, &xHigherPriorityTaskWoken);`
`111`	`110`	`}`