Per review.

dok-net · dok-net · commit cd7d137774c8 · 2021-04-04T19:36:38.000+02:00
diff --git a/cores/esp8266/uart.cpp b/cores/esp8266/uart.cpp
@@ -830,18 +830,11 @@ uart_set_tx(uart_t* uart, int tx_pin)
             {
                 return true;
             }
-            else if (tx_pin == 2)
+            else if (tx_pin == 1 || tx_pin == 2)
             {
                 pinMode(uart->tx_pin, INPUT);
                 uart->tx_pin = tx_pin;
-                pinMode(uart->tx_pin, FUNCTION_4);
-                return true;
-            }
-            else if (tx_pin != 2)
-            {
-                pinMode(uart->tx_pin, INPUT);
-                uart->tx_pin = 1;
-                pinMode(uart->tx_pin, SPECIAL);
+                pinMode(uart->tx_pin, tx_pin == 1 ? SPECIAL : FUNCTION_4);
                 return true;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -830,18 +830,11 @@ uart_set_tx(uart_t* uart, int tx_pin)`
`830`	`830`	`{`
`831`	`831`	`return true;`
`832`	`832`	`}`
`833`		`- else if (tx_pin == 2)`
	`833`	`+ else if (tx_pin == 1 \|\| tx_pin == 2)`
`834`	`834`	`{`
`835`	`835`	`pinMode(uart->tx_pin, INPUT);`
`836`	`836`	`uart->tx_pin = tx_pin;`
`837`		`- pinMode(uart->tx_pin, FUNCTION_4);`
`838`		`- return true;`
`839`		`- }`
`840`		`- else if (tx_pin != 2)`
`841`		`- {`
`842`		`- pinMode(uart->tx_pin, INPUT);`
`843`		`- uart->tx_pin = 1;`
`844`		`- pinMode(uart->tx_pin, SPECIAL);`
	`837`	`+ pinMode(uart->tx_pin, tx_pin == 1 ? SPECIAL : FUNCTION_4);`
`845`	`838`	`return true;`
`846`	`839`	`}`
`847`	`840`	`}`