Skip to content

Commit 22c7d79

Browse files
committed
Updater: place debug strings into progmem
1 parent 8b27047 commit 22c7d79

File tree

1 file changed

+19
-17
lines changed

1 file changed

+19
-17
lines changed

cores/esp8266/Updater.cpp

+19-17
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,14 @@ void UpdaterClass::_reset() {
3939
bool UpdaterClass::begin(size_t size, int command) {
4040
if(_size > 0){
4141
#ifdef DEBUG_UPDATER
42-
DEBUG_UPDATER.println("[begin] already running");
42+
DEBUG_UPDATER.println(F("[begin] already running"));
4343
#endif
4444
return false;
4545
}
4646

4747
#ifdef DEBUG_UPDATER
4848
if (command == U_SPIFFS) {
49-
DEBUG_UPDATER.println("[begin] Update SPIFFS.");
49+
DEBUG_UPDATER.println(F("[begin] Update SPIFFS."));
5050
}
5151
#endif
5252

@@ -103,7 +103,7 @@ bool UpdaterClass::begin(size_t size, int command) {
103103
else {
104104
// unknown command
105105
#ifdef DEBUG_UPDATER
106-
DEBUG_UPDATER.println("[begin] Unknown update command.");
106+
DEBUG_UPDATER.println(F("[begin] Unknown update command."));
107107
#endif
108108
return false;
109109
}
@@ -137,7 +137,7 @@ bool UpdaterClass::setMD5(const char * expected_md5){
137137
bool UpdaterClass::end(bool evenIfRemaining){
138138
if(_size == 0){
139139
#ifdef DEBUG_UPDATER
140-
DEBUG_UPDATER.println("no update");
140+
DEBUG_UPDATER.println(F("no update"));
141141
#endif
142142
return false;
143143
}
@@ -349,31 +349,33 @@ size_t UpdaterClass::writeStream(Stream &data) {
349349
}
350350

351351
void UpdaterClass::printError(Stream &out){
352-
out.printf("ERROR[%u]: ", _error);
352+
out.printf_P(PSTR("ERROR[%u]: "), _error);
353353
if(_error == UPDATE_ERROR_OK){
354-
out.println("No Error");
354+
out.println(F("No Error"));
355355
} else if(_error == UPDATE_ERROR_WRITE){
356-
out.println("Flash Write Failed");
356+
out.println(F("Flash Write Failed"));
357357
} else if(_error == UPDATE_ERROR_ERASE){
358-
out.println("Flash Erase Failed");
358+
out.println(F("Flash Erase Failed"));
359359
} else if(_error == UPDATE_ERROR_READ){
360-
out.println("Flash Read Failed");
360+
out.println(F("Flash Read Failed"));
361361
} else if(_error == UPDATE_ERROR_SPACE){
362-
out.println("Not Enough Space");
362+
out.println(F("Not Enough Space"));
363363
} else if(_error == UPDATE_ERROR_SIZE){
364-
out.println("Bad Size Given");
364+
out.println(F("Bad Size Given"));
365365
} else if(_error == UPDATE_ERROR_STREAM){
366-
out.println("Stream Read Timeout");
366+
out.println(F("Stream Read Timeout"));
367367
} else if(_error == UPDATE_ERROR_MD5){
368-
out.println("MD5 Check Failed");
368+
out.println(F("MD5 Check Failed"));
369369
} else if(_error == UPDATE_ERROR_FLASH_CONFIG){
370-
out.printf("Flash config wrong real: %d IDE: %d\n", ESP.getFlashChipRealSize(), ESP.getFlashChipSize());
370+
out.printf_P(PSTR("Flash config wrong real: %d IDE: %d\n"), ESP.getFlashChipRealSize(), ESP.getFlashChipSize());
371371
} else if(_error == UPDATE_ERROR_NEW_FLASH_CONFIG){
372-
out.printf("new Flash config wrong real: %d\n", ESP.getFlashChipRealSize());
372+
out.printf_P(PSTR("new Flash config wrong real: %d\n"), ESP.getFlashChipRealSize());
373373
} else if(_error == UPDATE_ERROR_MAGIC_BYTE){
374-
out.println("Magic byte is wrong, not 0xE9");
374+
out.println(F("Magic byte is wrong, not 0xE9"));
375+
} else if (_error == UPDATE_ERROR_BOOTSTRAP){
376+
out.println(F("Invalid bootstrapping state, reset ESP8266 before updating"));
375377
} else {
376-
out.println("UNKNOWN");
378+
out.println(F("UNKNOWN"));
377379
}
378380
}
379381

0 commit comments

Comments
 (0)