adding eslint rule to detect new buffer hotspot

Author: Adam Baldwin

index.js

@@ -17,7 +17,8 @@ module.exports = {
     'detect-buffer-noassert': require('./rules/detect-buffer-noassert'),
     'detect-child-process': require('./rules/detect-child-process'),
     'detect-disable-mustache-escape': require('./rules/detect-disable-mustache-escape'),
-    'detect-object-injection': require('./rules/detect-object-injection')
+    'detect-object-injection': require('./rules/detect-object-injection'),
+    'detect-new-buffer': require('./rules/detect-new-buffer')
   },
   rulesConfig: {
     'detect-unsafe-regex': 0,
@@ -31,6 +32,7 @@ module.exports = {
     'detect-buffer-noassert': 0,
     'detect-child-process': 0,
     'detect-disable-mustache-escape': 0,
-    'detect-object-injection': 0
+    'detect-object-injection': 0,
+    'detect-new-buffer': 0
   }
 };

rules/detect-new-buffer.js

@@ -0,0 +1,26 @@
+module.exports = function (context) {
+
+    var getSource = function (node) {
+        var token = context.getTokens(node)[0];
+        return token.loc.start.line+ ':  ' + context.getSourceLines().slice(token.loc.start.line-1, token.loc.end.line).join('\n\t');
+    }
+
+
+    // Detects instances of new Buffer(argument)
+    // where argument is any non literal value.
+    return {
+      "NewExpression": function (node) {
+        if (node.callee.name === 'Buffer' &&
+          node.arguments[0] &&
+          node.arguments[0].type != 'Literal') {
+
+          return context.report(node, "Found new Buffer\n\t" + getSource(node));
+        }
+
+
+
+      }
+    };
+
+}
+