Skip to content

Commit 8f8761a

Browse files
Savater Sebastienkarmi
Savater Sebastien
authored andcommitted
[MODEL] Added ActiveRecord 5 support to integration test configuration
1 parent e64baf3 commit 8f8761a

File tree

5 files changed

+19
-2
lines changed

5 files changed

+19
-2
lines changed

Rakefile

+3
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ namespace :bundle do
3535
sh "bundle install --gemfile #{__current__.join('elasticsearch-model/gemfiles')}/3.0.gemfile"
3636
puts '-'*80
3737
sh "bundle install --gemfile #{__current__.join('elasticsearch-model/gemfiles')}/4.0.gemfile"
38+
puts '-'*80
39+
sh "bundle install --gemfile #{__current__.join('elasticsearch-model/gemfiles')}/5.0.gemfile"
3840
end
3941

4042
desc "Remove Gemfile.lock in all subprojects"
@@ -45,6 +47,7 @@ namespace :bundle do
4547
end
4648
sh "rm -f #{__current__.join('elasticsearch-model/gemfiles')}/3.0.gemfile.lock"
4749
sh "rm -f #{__current__.join('elasticsearch-model/gemfiles')}/4.0.gemfile.lock"
50+
sh "rm -f #{__current__.join('elasticsearch-model/gemfiles')}/5.0.gemfile.lock"
4851
end
4952
end
5053

elasticsearch-model/.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,4 @@ tmp
1818

1919
gemfiles/3.0.gemfile.lock
2020
gemfiles/4.0.gemfile.lock
21+
gemfiles/5.0.gemfile.lock

elasticsearch-model/Rakefile

+2-1
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,11 @@ namespace :test do
3030
test.warning = false
3131
end
3232

33-
desc "Run integration tests against ActiveModel 3 and 4"
33+
desc "Run integration tests against ActiveModel 3, 4 and 5"
3434
task :integration do
3535
sh "BUNDLE_GEMFILE='#{File.expand_path('../gemfiles/3.0.gemfile', __FILE__)}' bundle exec rake test:run_integration" unless defined?(RUBY_VERSION) && RUBY_VERSION > '2.2'
3636
sh "BUNDLE_GEMFILE='#{File.expand_path('../gemfiles/4.0.gemfile', __FILE__)}' bundle exec rake test:run_integration"
37+
sh "BUNDLE_GEMFILE='#{File.expand_path('../gemfiles/5.0.gemfile', __FILE__)}' bundle exec rake test:run_integration"
3738
end
3839

3940
desc "Run unit and integration tests"

elasticsearch-model/elasticsearch-model.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Gem::Specification.new do |s|
3939
s.add_development_dependency "kaminari"
4040
s.add_development_dependency "will_paginate"
4141

42-
s.add_development_dependency "minitest", "~> 4.2"
42+
s.add_development_dependency "minitest", ">= 4.2"
4343
s.add_development_dependency "test-unit" if defined?(RUBY_VERSION) && RUBY_VERSION > '2.2'
4444
s.add_development_dependency "shoulda-context"
4545
s.add_development_dependency "mocha"
+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# Usage:
2+
#
3+
# $ BUNDLE_GEMFILE=./gemfiles/5.0.gemfile bundle install
4+
# $ BUNDLE_GEMFILE=./gemfiles/5.0.gemfile bundle exec rake test:integration
5+
6+
source 'https://rubygems.org'
7+
8+
gemspec path: '../'
9+
10+
gem 'activemodel', '~> 5'
11+
gem 'activerecord', '~> 5'
12+
gem 'sqlite3'

0 commit comments

Comments
 (0)