-
Notifications
You must be signed in to change notification settings - Fork 1.2k
FieldLookup should include "routing" property #2261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Workaround for anyone else running into this:
That plain ol' string property isn't going to do anything to make sure your routing value makes any sense, so caveat coder. |
Thanks @seanwm we'll add it to our next releases 👍 Side note: I'm super happy you were able to hack what you needed through implementing our interface with your own class. This is exactly why we made such a push for interface everywhere! 😄 |
Thanks. And yeah, I was really pleasantly surprised that I could just drop in my simple replacement class, kudos! |
Fix #2261 add missing Routing option to FieldsLookup
Fix #2261 add missing Routing option to FieldsLookup
Fix #2261 add missing Routing option to FieldsLookup
Describe the feature:
As documented here:
https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-terms-query.html
the Terms Query lookup supports a "routing" option, necessary when referencing a document in an index that uses custom routing. I need to use this, but NEST doesn't currently support that routing option with the FieldLookup class. Any chance we could see that added?
The text was updated successfully, but these errors were encountered: