Skip to content

Add information for setup with maven #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

sothawo
Copy link
Contributor

@sothawo sothawo commented Jun 11, 2021

This PR just adds a section to the readme about how to configure GitHub packages when using maven instead of gradle

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I left a minor nitpick!

Co-authored-by: Sylvain Wallez <sylvain@bluxte.net>
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@swallez swallez merged commit 2a66f6b into elastic:main Jun 17, 2021
@sothawo sothawo deleted the github_packages_with_maven branch July 24, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants