Skip to content

Fix META-INF path for LICENSE.TXT and NOTICE.TXT #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix META-INF path for LICENSE.TXT and NOTICE.TXT #6

merged 1 commit into from
Jun 10, 2021

Conversation

sothawo
Copy link
Contributor

@sothawo sothawo commented Jun 7, 2021

Changes the directory structure of the jar from

META-INF/
META-INF/MANIFEST.MF
META-INF/./
META-INF/./LICENSE.txt
META-INF/./NOTICE.txt

to

META-INF/
META-INF/MANIFEST.MF
META-INF/NOTICE.txt
META-INF/LICENSE.txt

Closes #5

@sothawo sothawo changed the title Fix METAINF path for LICENSE.TXT and NOTICE.TXT Fix META-INF path for LICENSE.TXT and NOTICE.TXT Jun 7, 2021
swallez
swallez approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks a lot for the fix @sothawo!

@swallez swallez merged commit bfb899e into elastic:main Jun 10, 2021
@swallez swallez mentioned this pull request Jun 11, 2021
Closed
@sothawo sothawo deleted the fix-metainf-for-license-and-notice-files branch July 24, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swallez swallez swallez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directory structure of elasticsearch-java-8.0.0-SNAPSHOT.jar contains /./
2 participants
@sothawo @swallez