Skip to content

feat: use yaml.v2 in export command #16611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kruskall
Copy link
Member

Motivation/summary

beats and related libs are using yaml.v2 to parse the config

yaml.v3 usage is causing the whole lib to be linked in the binary

use yaml.v2 so we standardize on one yaml library

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues

beats and related libs are using yaml.v2 to parse the config

yaml.v3 usage is causing the whole lib to be linked in the binary

use yaml.v2 so we standardize on one yaml library
@kruskall kruskall requested a review from a team as a code owner April 10, 2025 16:43
Copy link
Contributor

mergify bot commented Apr 10, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ericywl
Copy link
Contributor

ericywl commented Apr 11, 2025

Seems like there were slight differences in yaml.v3 and yaml.v2 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants