Skip to content

Commit 88fdb5f

Browse files
committed
Fixed iconv MINFO
1 parent 007406c commit 88fdb5f

File tree

1 file changed

+5
-21
lines changed

1 file changed

+5
-21
lines changed

ext/iconv/iconv.c

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -326,31 +326,15 @@ PHP_MSHUTDOWN_FUNCTION(miconv)
326326
/* {{{ PHP_MINFO_FUNCTION */
327327
PHP_MINFO_FUNCTION(miconv)
328328
{
329-
char *iconv_impl;
330-
char *version = "unknown";
329+
zval *iconv_impl, *iconv_ver;
331330

332-
#ifdef PHP_ICONV_IMPL
333-
iconv_impl = PHP_ICONV_IMPL;
334-
#elif HAVE_LIBICONV
335-
iconv_impl = "libiconv";
336-
{
337-
static char buf[16];
338-
snprintf(buf, sizeof(buf), "%d.%d",
339-
((_libiconv_version >> 8) & 0x0f), (_libiconv_version & 0x0f));
340-
version = buf;
341-
}
342-
#elif defined(NETWARE)
343-
iconv_impl = "Novell";
344-
version = "OS built-in";
345-
#else
346-
iconv_impl = "unknown";
347-
version = (char *)gnu_get_libc_version();
348-
#endif
331+
iconv_impl = zend_get_constant_str("ICONV_IMPL", sizeof("ICONV_IMPL")-1 TSRMLS_CC);
332+
iconv_ver = zend_get_constant_str("ICONV_VERSION", sizeof("ICONV_VERSION")-1 TSRMLS_CC);
349333

350334
php_info_print_table_start();
351335
php_info_print_table_row(2, "iconv support", "enabled");
352-
php_info_print_table_row(2, "iconv implementation", iconv_impl);
353-
php_info_print_table_row(2, "iconv library version", version);
336+
php_info_print_table_row(2, "iconv implementation", Z_STRVAL_P(iconv_impl));
337+
php_info_print_table_row(2, "iconv library version", Z_STRVAL_P(iconv_ver));
354338
php_info_print_table_end();
355339

356340
DISPLAY_INI_ENTRIES();

0 commit comments

Comments
 (0)