Skip to content

Commit 3563943

Browse files
committed
Error reporting clean up
1 parent 6317e26 commit 3563943

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

ext/rpc/com/com_wrapper.c

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,19 +76,22 @@
7676
int resourcecounter = 1;
7777
#endif
7878

79-
ZEND_API HRESULT php_COM_invoke(comval *obj, DISPID dispIdMember, WORD wFlags, DISPPARAMS FAR* pDispParams, VARIANT FAR* pVarResult, char **ErrString)
79+
ZEND_API HRESULT php_COM_invoke(comval *obj, DISPID dispIdMember, WORD wFlags,
80+
DISPPARAMS FAR* pDispParams, VARIANT FAR* pVarResult, char **ErrString)
8081
{
8182
HRESULT hr;
8283
int failed = FALSE;
83-
unsigned int ArgErr;
84+
unsigned int ArgErr = 0;
8485
EXCEPINFO ExceptInfo;
8586

8687
*ErrString = NULL;
8788
/* @todo use DispInvoke here ? */
8889
if (C_HASTLIB(obj)) {
89-
hr = C_TYPEINFO_VT(obj)->Invoke(C_TYPEINFO(obj), C_DISPATCH(obj), dispIdMember, wFlags, pDispParams, pVarResult, &ExceptInfo, &ArgErr);
90+
hr = C_TYPEINFO_VT(obj)->Invoke(C_TYPEINFO(obj), C_DISPATCH(obj),
91+
dispIdMember, wFlags, pDispParams, pVarResult, &ExceptInfo, &ArgErr);
9092
if (FAILED(hr)) {
91-
hr = C_DISPATCH_VT(obj)->Invoke(C_DISPATCH(obj), dispIdMember, &IID_NULL, LOCALE_SYSTEM_DEFAULT, wFlags, pDispParams, pVarResult, &ExceptInfo, &ArgErr);
93+
hr = C_DISPATCH_VT(obj)->Invoke(C_DISPATCH(obj), dispIdMember, &IID_NULL,
94+
LOCALE_SYSTEM_DEFAULT, wFlags, pDispParams, pVarResult, &ExceptInfo, &ArgErr);
9295
if (SUCCEEDED(hr)) {
9396
/*
9497
* ITypLib doesn't work
@@ -100,7 +103,8 @@ ZEND_API HRESULT php_COM_invoke(comval *obj, DISPID dispIdMember, WORD wFlags, D
100103
}
101104
}
102105
} else {
103-
hr = C_DISPATCH_VT(obj)->Invoke(C_DISPATCH(obj), dispIdMember, &IID_NULL, LOCALE_SYSTEM_DEFAULT, wFlags, pDispParams, pVarResult, &ExceptInfo, &ArgErr);
106+
hr = C_DISPATCH_VT(obj)->Invoke(C_DISPATCH(obj), dispIdMember, &IID_NULL,
107+
LOCALE_SYSTEM_DEFAULT, wFlags, pDispParams, pVarResult, &ExceptInfo, &ArgErr);
104108
}
105109

106110
if (FAILED(hr)) {
@@ -137,7 +141,7 @@ ZEND_API HRESULT php_COM_invoke(comval *obj, DISPID dispIdMember, WORD wFlags, D
137141
break;
138142
case DISP_E_PARAMNOTFOUND:
139143
case DISP_E_TYPEMISMATCH:
140-
spprintf(ErrString, 0, "<b>Argument</b>: %d", pDispParams->cArgs-ArgErr+1);
144+
spprintf(ErrString, 0, "<b>Argument</b>: %d", pDispParams->cArgs - ArgErr);
141145
break;
142146
}
143147
}
@@ -555,7 +559,7 @@ ZEND_API int php_COM_process_typeinfo(ITypeInfo *typeinfo, HashTable *id_to_name
555559

556560
ret = 1;
557561
} else {
558-
zend_error(E_WARNING, "Thats not a dispatchable interface!! type kind = %08x", attr->typekind);
562+
zend_error(E_WARNING, "That's not a dispatchable interface!! type kind = %08x", attr->typekind);
559563
}
560564

561565
typeinfo->lpVtbl->ReleaseTypeAttr(typeinfo, attr);

0 commit comments

Comments
 (0)